Support use of container images not built by TripleO (like DockerCephDaemonImage) in image prepare command

[Giulio Fidente]

The docker images used by ceph-ansible are configured via DockerCephDaemonImage and they are not built by TripleO so they are not in the tripleoupstream namespace.

It would be nice if we could use the --set argument [1] of image prepare to set the template parameter value appropriately.

Some deployments, like RDO, currently use the --pull-source argument to download images from a "better" docker registry but they only want the custom registry host to be set for the TripleO images; it would be nice if we could also add an 'exception' rule to avoid the custom source being used for the other images. I suppose the same holds true for --push--destination.

1. https://review.openstack.org/#/c/489083/

[Giulio Fidente (gfidente)]

Steve, not sure if you can volunteer any work to fix this?

[Steve Baker (steve-stevebaker)]

This is why --pull-source has been deprecated as per bug #1708303. The source registry for kolla containers is set with a fully qualified --namespace docker.io/tripleoupstream/...

Likewise the ceph container source would be specified with something like --set ceph-namespace=docker.io/ceph/daemon...

[Steve Baker (steve-stevebaker)]

But lets use this bug to actually track the change to overcloud_containers.yaml.j2 to define the ceph template variables

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/499822

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/493391
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=e8e41e2d9d8a81b158683603362813c4e0c3564d
Submitter: Jenkins
Branch: master

commit e8e41e2d9d8a81b158683603362813c4e0c3564d
Author: Steve Baker <email address hidden>
Date: Mon Aug 14 13:18:38 2017 +1200

    Stop using deprecated --pull-source

    --pull-source has beed deprecated since it interacts poorly with
    non-kolla images such as ceph. This change switches to fully-qualified
    --namespace arguments instead.

    Also the --exclude ceph is no longer required due to the service based
    image filtering.

    Change-Id: I7f7950ba7c95d42f23246932fb27f1ab457590d1
    Related-Bug: #1708303
    Related-Bug: #1714225
    Closes-Bug: #1714412

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/501702

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499822
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=020103b31091757babe56b2bc801598d566bc75c
Submitter: Jenkins
Branch: master

commit 020103b31091757babe56b2bc801598d566bc75c
Author: Steve Baker <email address hidden>
Date: Fri Sep 1 09:48:43 2017 +1200

    Define ceph image in overcloud_containers.yaml.j2

    This change allows the ceph container image to be included in the
    kolla image prepare workflow, even when coming from a different build
    pipeline and source registry.

    Defaults can be overridden using --set. The following achieves the
    same as the defaults:

      openstack overcloud container image prepare \
        --set ceph_namespace=ceph \
        --set ceph_image=daemon \
        --set ceph_tag=tag-build-master-jewel-centos-7

    Change-Id: Ib8427bfbdc44cf36ce2b71e1a9746354c96768d8
    Closes-Bug: #1714225

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501702
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=37680f29857197ce894c19a0780515b971223db9
Submitter: Jenkins
Branch: stable/pike

commit 37680f29857197ce894c19a0780515b971223db9
Author: Steve Baker <email address hidden>
Date: Fri Sep 1 09:48:43 2017 +1200

    Define ceph image in overcloud_containers.yaml.j2

    This change allows the ceph container image to be included in the
    kolla image prepare workflow, even when coming from a different build
    pipeline and source registry.

    Defaults can be overridden using --set. The following achieves the
    same as the defaults:

      openstack overcloud container image prepare \
        --set ceph_namespace=ceph \
        --set ceph_image=daemon \
        --set ceph_tag=tag-build-master-jewel-centos-7

    Change-Id: Ib8427bfbdc44cf36ce2b71e1a9746354c96768d8
    Closes-Bug: #1714225
    (cherry picked from commit 020103b31091757babe56b2bc801598d566bc75c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 7.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.0.0 release.