CI. periodic master job fails because "ERROR: Error in 77 output role_data: No function "#operator_+" matches supplied arguments"

[Sagi (Sergey) Shnaidman]

last promotion job periodic-tripleo-ci-centos-7-ovb-ha-oooq failed to deploy overcloud:

ERROR: Error in 77 output role_data: No function "#operator_+" matches supplied arguments

http://logs.openstack.org/periodic/periodic-tripleo-ci-centos-7-ovb-ha-oooq/2207760/logs/undercloud/home/jenkins/overcloud_deploy.log.txt.gz#_2017-08-30_09_37_11

[Thomas Herve (therve)]

While it looks like a Heat issue, it doesn't seem that the Heat version is changed by that job (ie we have passing test on master with the same version).

[Thomas Herve (therve)]

It would appear to come from here: https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/nova-api.yaml#L203

One of apache_upgrade or nova_api_upgrade (at least) evaluates to null or the empty string.

But it doesn't look like it changed recently.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/499157

[Thomas Herve (therve)]

So the patch I linked is mostly moving away from yaql, so that we could get a better error. I don't think it fixes the issue, but it's worth a try.

[Thomas Herve (therve)]

Removing the flags, as today job passed without any particular change that I can see.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499157
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8008089de24437757d3ba10299bb1041b4aa627a
Submitter: Jenkins
Branch: master

commit 8008089de24437757d3ba10299bb1041b4aa627a
Author: Thomas Herve <email address hidden>
Date: Wed Aug 30 15:43:16 2017 +0200

    Use list_concat in place of yaql

    Where applicable, use list_concat instead of yaql to build new lists: it
    should be more resilient to errors, easier to debug, and less expensive.

    Change-Id: I6d3dbc7ee8eac50f46023a35af4ec7f2d378fd87
    Related-Bug: #1714005

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/500172

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/500172
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=fe975e8626b27817842eea0e4babbb7d72a919bf
Submitter: Jenkins
Branch: stable/pike

commit fe975e8626b27817842eea0e4babbb7d72a919bf
Author: Thomas Herve <email address hidden>
Date: Wed Aug 30 15:43:16 2017 +0200

    Use list_concat in place of yaql

    Where applicable, use list_concat instead of yaql to build new lists: it
    should be more resilient to errors, easier to debug, and less expensive.

    Change-Id: I6d3dbc7ee8eac50f46023a35af4ec7f2d378fd87
    Related-Bug: #1714005
    (cherry picked from commit 8008089de24437757d3ba10299bb1041b4aa627a)