Generated SSL environments are out of sync

Bug #1713761 reported by Ben Nemec on 2017-08-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Ben Nemec

Bug Description

Some of the generated SSL environments were modified by hand and the tool configuration needs to be updated to reflect this (a pep8 check that the templates are in sync is also something we need, but that's for the future). There was also an SSL environment missed in the conversion that should be addressed before the final Pike release.

There are already patches up to fix both of these issues, but now that we've branched I'll need a bug to backport them.

Changed in tripleo:
status: Triaged → In Progress

Reviewed: https://review.openstack.org/493245
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=406b1982ba530abdd6c629780130851e8e335ae8
Submitter: Jenkins
Branch: master

commit 406b1982ba530abdd6c629780130851e8e335ae8
Author: Ben Nemec <email address hidden>
Date: Fri Aug 11 16:17:17 2017 -0500

    Update generated ssl environments

    These were edited manually and the input file was not updated, which
    is causing problems when trying to generate new/updated envs.

    Change-Id: Ia2e53e52361e35d94e2dedf9b8885498693bc2e0
    Partial-Bug: 1713761

Reviewed: https://review.openstack.org/499896
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7ef0b96d4e81064a8219d14b6990bb4f2eb7bdeb
Submitter: Jenkins
Branch: stable/pike

commit 7ef0b96d4e81064a8219d14b6990bb4f2eb7bdeb
Author: Ben Nemec <email address hidden>
Date: Fri Aug 11 16:17:17 2017 -0500

    Update generated ssl environments

    These were edited manually and the input file was not updated, which
    is causing problems when trying to generate new/updated envs.

    Change-Id: Ia2e53e52361e35d94e2dedf9b8885498693bc2e0
    Partial-Bug: 1713761
    (cherry picked from commit 406b1982ba530abdd6c629780130851e8e335ae8)

tags: added: in-stable-pike

Reviewed: https://review.openstack.org/493246
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7c06db3d1c384773c4abccbce450c259f75e5e4a
Submitter: Jenkins
Branch: master

commit 7c06db3d1c384773c4abccbce450c259f75e5e4a
Author: Ben Nemec <email address hidden>
Date: Fri Aug 11 16:31:01 2017 -0500

    Convert enable-internal-tls.yaml to be generated

    All of the other SSL environments were converted, but this one was
    missed. That's an inconsistent user experience and should be
    cleaned up.

    This environment also exposed a bug in the tool where it did not
    include the parameter_defaults section key if all the parameters
    were marked static.

    Change-Id: I19bc422c22b9f60f781e696ce703b026dc317786
    Closes-Bug: 1713761

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/500247
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ca4b08bb6df610f7eea6e40e9e0ca445091369fa
Submitter: Jenkins
Branch: stable/pike

commit ca4b08bb6df610f7eea6e40e9e0ca445091369fa
Author: Ben Nemec <email address hidden>
Date: Fri Aug 11 16:31:01 2017 -0500

    Convert enable-internal-tls.yaml to be generated

    All of the other SSL environments were converted, but this one was
    missed. That's an inconsistent user experience and should be
    cleaned up.

    This environment also exposed a bug in the tool where it did not
    include the parameter_defaults section key if all the parameters
    were marked static.

    Change-Id: I19bc422c22b9f60f781e696ce703b026dc317786
    Closes-Bug: 1713761
    (cherry picked from commit 7c06db3d1c384773c4abccbce450c259f75e5e4a)

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0rc2 release candidate.

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers