configure_safe_defaults() should handle failure of carrier check

Bug #1712687 reported by Bob Fournier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Bob Fournier

Bug Description

In network/scripts/run-os-net-config.sh, configure_safe_defaults() should handle carrier check failures in the same way as the change that was made to dhcp-all-interfaces.sh here: https://review.openstack.org/#/c/419527/. That is, it should ignore failures when cat'ing the carrier file.

Bob Fournier (bfournie)
Changed in tripleo:
status: New → Confirmed
assignee: nobody → Bob Fournier (bfournie)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/497232

Changed in tripleo:
status: Confirmed → In Progress
Changed in tripleo:
importance: Undecided → High
milestone: none → pike-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/497232
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ed976d285caab1858f0b6e74e14a723113d27052
Submitter: Jenkins
Branch: master

commit ed976d285caab1858f0b6e74e14a723113d27052
Author: Bob Fournier <email address hidden>
Date: Wed Aug 23 17:15:34 2017 -0400

    Handle failure of carrier check in configure_safe_defaults()

    Configure_safe_defaults() should handle carrier check failures
    in the same way as the change that was made to
    dhcp-all-interfaces.sh in https://review.openstack.org/#/c/419527/.
    That is, it should ignore failures when cat'ing the carrier file.

    Change-Id: I100a40835d0ccecee9b4851aae6366c6ab4813a5
    Closes-Bug: 1712687

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/498205

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/pike)

Reviewed: https://review.openstack.org/498205
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=56eaad835dde784a963d8802f862d9827ec942ed
Submitter: Jenkins
Branch: stable/pike

commit 56eaad835dde784a963d8802f862d9827ec942ed
Author: Bob Fournier <email address hidden>
Date: Wed Aug 23 17:15:34 2017 -0400

    Handle failure of carrier check in configure_safe_defaults()

    Configure_safe_defaults() should handle carrier check failures
    in the same way as the change that was made to
    dhcp-all-interfaces.sh in https://review.openstack.org/#/c/419527/.
    That is, it should ignore failures when cat'ing the carrier file.

    Change-Id: I100a40835d0ccecee9b4851aae6366c6ab4813a5
    Closes-Bug: 1712687
    (cherry picked from commit ed976d285caab1858f0b6e74e14a723113d27052)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 7.0.0.0rc2

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.0.0b1

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.