hardcoded reference to deprecated NovaComputeSchedulerHints

Bug #1711656 reported by Steven Hardy on 2017-08-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Steven Hardy

Bug Description

https://review.openstack.org/#/c/482623/ made the use of the deprecated NovaComputeSchedulerHints parameter optional, and a roles_data without specifying it should work, but I didn't spot a use of this in the parent overcloud.j2.yaml template.

Steven Hardy (shardy) on 2017-08-18
Changed in tripleo:
status: New → Triaged
milestone: none → pike-rc1
assignee: nobody → Steven Hardy (shardy)
importance: Undecided → High

Fix proposed to branch: master
Review: https://review.openstack.org/495324

Changed in tripleo:
status: Triaged → In Progress

Fix proposed to branch: master
Review: https://review.openstack.org/496604

Steven Hardy (shardy) wrote :

We had the same issue with *ExtraConfig so the second patch above addresses that

Changed in tripleo:
milestone: pike-rc1 → pike-rc2

Reviewed: https://review.openstack.org/495324
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c6207379db07544240b699ba000537b58d9fb68f
Submitter: Jenkins
Branch: master

commit c6207379db07544240b699ba000537b58d9fb68f
Author: Steven Hardy <email address hidden>
Date: Wed Aug 23 08:39:18 2017 +0100

    Move deprecated SchedulerHints logic to overcloud.j2.yaml

    The changes in puppet/role.role.j2.yaml should have been made
    to overcloud.j2.yaml, because we don't want the hard-coded reference
    to the deprecated name in the parent template. Note we need to
    pass this value from the parent template so the %index% substitution
    works, which is required for predictable placement via *SchedulerHints

    Partial-Bug: #1711656
    Change-Id: Ided1802daac48d737f53caa7093df814ba101dd0

Reviewed: https://review.openstack.org/499440
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=af7146888bfc8888bf1086d8a23c36d32130ae10
Submitter: Jenkins
Branch: stable/pike

commit af7146888bfc8888bf1086d8a23c36d32130ae10
Author: Steven Hardy <email address hidden>
Date: Wed Aug 23 08:39:18 2017 +0100

    Move deprecated SchedulerHints logic to overcloud.j2.yaml

    The changes in puppet/role.role.j2.yaml should have been made
    to overcloud.j2.yaml, because we don't want the hard-coded reference
    to the deprecated name in the parent template. Note we need to
    pass this value from the parent template so the %index% substitution
    works, which is required for predictable placement via *SchedulerHints

    Partial-Bug: #1711656
    Change-Id: Ided1802daac48d737f53caa7093df814ba101dd0
    (cherry picked from commit c6207379db07544240b699ba000537b58d9fb68f)

tags: added: in-stable-pike

Reviewed: https://review.openstack.org/496604
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4a4f6783081d9c5b74cda5149bef7655102fcfd8
Submitter: Jenkins
Branch: master

commit 4a4f6783081d9c5b74cda5149bef7655102fcfd8
Author: Steven Hardy <email address hidden>
Date: Wed Aug 23 11:23:10 2017 +0100

    Fix hardcoded references to deprecated *ExtraConfig parameters

    These were missed in the previous refactor in role.role.j2.yaml,
    we shouldn't reference these via hard-coded values or they become
    mandatory in the roles_data.yaml

    Change-Id: I014e7d6679c5733b17243d647eaad228c276585a
    Closes-Bug: #1711656

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/500223
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=878d236f7bd1aaa214acd37a74477c109ba756f2
Submitter: Jenkins
Branch: stable/pike

commit 878d236f7bd1aaa214acd37a74477c109ba756f2
Author: Steven Hardy <email address hidden>
Date: Wed Aug 23 11:23:10 2017 +0100

    Fix hardcoded references to deprecated *ExtraConfig parameters

    These were missed in the previous refactor in role.role.j2.yaml,
    we shouldn't reference these via hard-coded values or they become
    mandatory in the roles_data.yaml

    Change-Id: I014e7d6679c5733b17243d647eaad228c276585a
    Closes-Bug: #1711656
    (cherry picked from commit 4a4f6783081d9c5b74cda5149bef7655102fcfd8)

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0rc2 release candidate.

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers