Fix tripleo-common path in container health check scripts

Bug #1710629 reported by Martin Mágr on 2017-08-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Martin Mágr

Bug Description

Currently container health check scripts are using /usr/share/tripleo-common/, but only /usr/share/openstack-tripleo-common/ is available in container images:

[root@overcloud-controller-0 ~]# docker logs d9b565562029
INFO:__main__:Loading config file at /var/lib/kolla/config_files/config.json
INFO:__main__:Validating config file
INFO:__main__:Kolla config strategy set to: COPY_ALWAYS
INFO:__main__:Copying service configuration files
INFO:__main__:Copying /var/lib/kolla/config_files/src/etc/my.cnf.d/tripleo.cnf to /etc/my.cnf.d/tripleo.cnf
INFO:__main__:Deleting /etc/nova/nova.conf
INFO:__main__:Copying /var/lib/kolla/config_files/src/etc/nova/nova.conf to /etc/nova/nova.conf
INFO:__main__:Copying /var/lib/kolla/config_files/src/var/spool/cron/nova to /var/spool/cron/nova
INFO:__main__:Writing out command to execute
INFO:__main__:Setting permission for /var/log/nova
INFO:__main__:Setting permission for /var/log/nova/nova-manage.log
INFO:__main__:Setting permission for /var/log/nova/nova-scheduler.log
INFO:__main__:Setting permission for /var/log/nova/nova-consoleauth.log
INFO:__main__:Setting permission for /var/log/nova/nova-novncproxy.log
INFO:__main__:Setting permission for /var/log/nova/nova-conductor.log
Running command: '/usr/bin/nova-api'
[root@overcloud-controller-0 ~]# docker exec -it d9b565562029 /bin/bash
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
()[nova@overcloud-controller-0 /]$ ls -l /openstack/
total 0
lrwxrwxrwx. 1 root root 46 Aug 11 18:17 healthcheck -> /usr/share/tripleo-common/healthcheck/nova-api
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
()[nova@overcloud-controller-0 /]$ /openstack/healthcheck
bash: /openstack/healthcheck: No such file or directory
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
()[nova@overcloud-controller-0 /]$ ls -l /usr/share/tripleo-common/healthcheck/nova-api
ls: cannot access /usr/share/tripleo-common/healthcheck/nova-api: No such file or directory
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
()[nova@overcloud-controller-0 /]$ ls -l /usr/share/tripleo-common/healthcheck/
ls: cannot access /usr/share/tripleo-common/healthcheck/: No such file or directory
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
()[nova@overcloud-controller-0 /]$ ls -l /usr/share/tripleo-common/
ls: cannot access /usr/share/tripleo-common/: No such file or directory
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
()[nova@overcloud-controller-0 /]$ ls -l /usr/share/ | grep tripleo
drwxr-xr-x. 3 root root 25 Aug 11 15:16 openstack-tripleo-common
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
()[nova@overcloud-controller-0 /]$ /usr/share/openstack-tripleo-common/healthcheck/nova-api
/usr/share/openstack-tripleo-common/healthcheck/nova-api: line 3: /usr/share/tripleo-common/healthcheck/common.sh: No such file or directory
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
()[nova@overcloud-controller-0 /]$

Changed in tripleo:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Changed in tripleo:
importance: Undecided → High
milestone: none → pike-rc1

Reviewed: https://review.openstack.org/493528
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=1abff9af09d4a4819bae87329b45027daa4b2a07
Submitter: Jenkins
Branch: master

commit 1abff9af09d4a4819bae87329b45027daa4b2a07
Author: Martin Mágr <email address hidden>
Date: Mon Aug 14 14:42:28 2017 +0200

    Use correct path in healthcheck scripts

    Currently /usr/share/tripleo-common is used in healthcheck scripts,
    but only /usr/share/openstack-tripleo-common is available in container
    images

    Closes-Bug: #1710629
    Change-Id: Id7d169cfd34bf2a45e9bff0e389e77189cb774d7

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/tripleo-common 7.5.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers