Unable to provide a suffix "-docker" to build container image registry

Bug #1709777 reported by Saravanan KR on 2017-08-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Saravanan KR

Bug Description

"openstack overcloud container image prepare" command is expecting the suffix to be provided with hypen like "-docker" to construct the image name like "openstack-nova-compute-docker". But argparse does not allow "-" (hypen) as start of option's value. So it is not possible to construct a image name with suffix.

Hypens can be internally added if a valid suffix is provided. Need to modify tripleo-common/container-images/overcloud_containers.yaml.j2 to handle this case.

Saravanan KR (skramaja) on 2017-08-10
Changed in tripleo:
importance: Undecided → Medium
assignee: nobody → Saravanan KR (skramaja)
milestone: none → pike-rc1

Fix proposed to branch: master
Review: https://review.openstack.org/492385

Changed in tripleo:
status: New → In Progress
Changed in tripleo:
importance: Medium → High

Reviewed: https://review.openstack.org/492385
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7f79a55edc3e2dea51e65047af1708eb4d0745e3
Submitter: Jenkins
Branch: master

commit 7f79a55edc3e2dea51e65047af1708eb4d0745e3
Author: Saravanan KR <email address hidden>
Date: Thu Aug 10 11:40:48 2017 +0530

    Add hypen to the prefix/suffix of container name if not provided

    If suffix is provided without hypen at the start, prefix hypen
    to the suffix, to support creation of image names like
    openstack-nova-compute-docker, where docker is the suffix.
    Also if prefix is provided without hypen at the end, add hypen
    at the end of the prefix.
    Closes-Bug: #1709777

    Change-Id: I2330a6f35a12bf140da8b52114cb20844efc5554

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/tripleo-common 7.5.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers