pcs output changed and upgrade to newton is broken.

[Sofer Athlan-Guyot]

Hi,

originally reported there https://bugzilla.redhat.com/show_bug.cgi?id=1476711.

m->n upgrade: major-upgrade-pacemaker.yaml fails with

ug 02 23:24:30 overcloud-controller-0 os-collect-config[2026]: [2017-08-02 23:24:30,818] (heat-config) [DEBUG] Running /var/lib/heat-config/hooks/script < /var/lib/heat-config/deployed/326ffa9c-fe78-403c-8658-95e79e0eb662.json
Aug 02 23:24:43 overcloud-controller-0 os-collect-config[2026]: [2017-08-02 23:24:43,575] (heat-config) [INFO] {"deploy_stdout": "mysql upgrade required: 0\nWed Aug 2 23:24:43 UTC 2017 326ffa9c-fe78-403c-8658-95e79e0eb662 tripleo-upgrade overcloud-controller-0 Deleting colocation constraint INFINITY from CIB\n", "deploy_stderr": "Error: Unable to find constraint - 'INFINITY'\n", "deploy_status_code": 1}

-> Error: Unable to find constraint - 'INFINITY'

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

Should be solved there https://review.openstack.org/#/c/490422/, first test round seems to be positive (see bz)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/490422
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ce75b84ddcca3258f298e0fe283358ebe55bdd8d
Submitter: Jenkins
Branch: stable/newton

commit ce75b84ddcca3258f298e0fe283358ebe55bdd8d
Author: Sofer Athlan-Guyot <email address hidden>
Date: Thu Aug 3 12:49:44 2017 +0200

    Adjust for new pcs output.

    The pcs config show command output has changed.

    It need to be passed the --full option in order to do its job now.

    So before we had:

        pcs config show | sed -n '/^Ordering Constraints:/,/^Colocation Constraints:$/p' | grep -v "Ordering Constraints:" | awk '{print $NF}' | cut -f2 -d: |cut -f1 -d\)
        order-ip-192.0.2.19-haproxy-clone-Optional
        order-ip-192.0.2.20-haproxy-clone-Optional
        ...

    now we have

        pcs config show | sed -n '/^Ordering Constraints:/,/^Colocation Constraints:$/p' | grep -v "Ordering Constraints:" | awk '{print $NF}' | cut -f2 -d: |cut -f1 -d\)
        Optional
        Optional

    adding the "--full" put the id back.

    Closes-Bug: #1708427

    Change-Id: I4931cb2230e3f46d191e345cd110132d88cb1b19

[Ben Nemec (bnemec)]

Does this affect any release other than newton (I hope not since apparently we merged the fix directly to newton) or can we close it against master?

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

Hi Ben,

Those upgrade tasks are specific to each version and don't repeat themselves in every version. Another similar fix was done for Mitaka (downstream only) but on another file. No such error manifested itself in ocata yet and shouldn't as pcs status --full is already used (the default pcs version must have been higher at the time of development).

We should close it against master.

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

This is not relevant against master. See https://bugs.launchpad.net/tripleo/+bug/1708427/comments/4

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.3.1 release.