--pull-source should be deprecated for prepare calls

Bug #1708303 reported by Steve Baker on 2017-08-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Steve Baker

Bug Description

There is a inconsistency when running prepare for upload vs prepare for deploy

To create an env-file we run:
openstack overcloud container image prepare --namespace=<FQDN:PORT/namespace> --env-file <filename> ...<args>

To create --images-file we run:
openstack overcloud container image prepare --namespace <namespace> --images-file <filename> --pull-source <FQDN:PORT>

I suggest that --pull-source be deprecated and we document that --namespace should always be fully qualified including the registry FQDN:PORT where necessary.

Changed in tripleo:
status: New → Triaged
tags: added: containers
Changed in tripleo:
importance: Undecided → Medium
assignee: nobody → Steve Baker (steve-stevebaker)
milestone: none → pike-rc1
Changed in tripleo:
status: Triaged → In Progress
Steve Baker (steve-stevebaker) wrote :

I'm setting this to High because bug #1708967 depends on it

Changed in tripleo:
importance: Medium → High
Changed in tripleo:
milestone: pike-rc1 → pike-rc2

Reviewed: https://review.openstack.org/494366
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=8c328b659ebf6c328d483b09e5df30cb8955be17
Submitter: Jenkins
Branch: master

commit 8c328b659ebf6c328d483b09e5df30cb8955be17
Author: Steve Baker <email address hidden>
Date: Mon Aug 14 12:53:02 2017 +1200

    Deprecate --pull-source for container prepare command

    The registry should be included in the --namespace argument to be
    consistent with the other image references.

    Change-Id: I0b0b8728b7752bdd4680a5a2bbf664f94f7d56d9
    Closes-Bug: #1708303
    Depends-On: I1769c7cf1c058328a8490228bdc4719e8d216ccb

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/493391
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=e8e41e2d9d8a81b158683603362813c4e0c3564d
Submitter: Jenkins
Branch: master

commit e8e41e2d9d8a81b158683603362813c4e0c3564d
Author: Steve Baker <email address hidden>
Date: Mon Aug 14 13:18:38 2017 +1200

    Stop using deprecated --pull-source

    --pull-source has beed deprecated since it interacts poorly with
    non-kolla images such as ceph. This change switches to fully-qualified
    --namespace arguments instead.

    Also the --exclude ceph is no longer required due to the service based
    image filtering.

    Change-Id: I7f7950ba7c95d42f23246932fb27f1ab457590d1
    Related-Bug: #1708303
    Related-Bug: #1714225
    Closes-Bug: #1714412

This issue was fixed in the openstack/python-tripleoclient 8.0.0 release.

Reviewed: https://review.openstack.org/518040
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=a669bbf03a12840dd2eb8ac56e336d6fb6213376
Submitter: Zuul
Branch: stable/pike

commit a669bbf03a12840dd2eb8ac56e336d6fb6213376
Author: Steve Baker <email address hidden>
Date: Mon Aug 14 12:53:02 2017 +1200

    Deprecate --pull-source for container prepare command

    The registry should be included in the --namespace argument to be
    consistent with the other image references.

    Change-Id: I0b0b8728b7752bdd4680a5a2bbf664f94f7d56d9
    Closes-Bug: #1708303
    Depends-On: I1769c7cf1c058328a8490228bdc4719e8d216ccb
    (cherry picked from commit 8c328b659ebf6c328d483b09e5df30cb8955be17)

tags: added: in-stable-pike

This issue was fixed in the openstack/python-tripleoclient 7.3.4 release.

Reviewed: https://review.openstack.org/516138
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=aaf46be238f554148b40748dbd4eafec759038ed
Submitter: Zuul
Branch: master

commit aaf46be238f554148b40748dbd4eafec759038ed
Author: Steve Baker <email address hidden>
Date: Mon Oct 30 10:28:51 2017 +1300

    Finish deprecation of pull_source

    In change I0b0b8728b7752bdd4680a5a2bbf664f94f7d56d9 the --pull-source
    argument was deprecated in favour of a --namespace which includes the
    source registry.

    This change makes the default namespace docker.io/tripleoupstream to
    be consistent with the default that the CLI uses. Tests now do not use
    pull_source so that proper testing of fully qualified namespace
    arguments is done.

    Change-Id: Icd29f0e75c3edadfb008056af774e283200002b0
    Related-Bug: #1708303

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers