paunch always exits 0, the ansible tasks never fail

Bug #1707997 reported by James Slagle on 2017-08-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
paunch
High
James Slagle
tripleo
High
James Slagle

Bug Description

it should instead exit nonzero in the case of failure.

this will cause the ansible debug tasks to fail, which I believe is the actual intent considering they are doing:

     - debug: var=(outputs.stderr|default('')).split('\n')|union(outputs.stdout_lines|default([]))
       when: outputs is defined
       failed_when: outputs|failed

Changed in tripleo:
status: New → In Progress
importance: Undecided → High
assignee: nobody → James Slagle (james-slagle)
milestone: none → pike-rc1
Changed in paunch:
status: New → In Progress
importance: Undecided → High
assignee: nobody → James Slagle (james-slagle)

Reviewed: https://review.openstack.org/489722
Committed: https://git.openstack.org/cgit/openstack/paunch/commit/?id=d11e04548e43c0ad099910cfacdb02d43e8a3a7c
Submitter: Jenkins
Branch: master

commit d11e04548e43c0ad099910cfacdb02d43e8a3a7c
Author: James Slagle <email address hidden>
Date: Tue Aug 1 15:36:56 2017 -0400

    paunch apply should exit nonzero for failures

    Exit with the return code (nonzero) in case of a failure during paunch
    apply. When executing commands such as "docker run..." the actual docker
    return code will be used as the exit code, which is what we want so that
    the ansible tasks running paunch will actually fail.

    Change-Id: Ic656d27c4428249c5394dcd9f998c5bb4e264250
    Partial-Bug: #1707997

Changed in tripleo:
status: In Progress → Fix Released
Changed in paunch:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers