Deleting/moving the undercloud-passwords.conf file can break the undercloud

[Ben Nemec]

If a user deletes or moves the undercloud-passwords.conf file that is generated during deployment, all of their passwords will be re-generated on their next undercloud update. Because some of these values need to remain the same (for example, the Heat encryption key) this will break the undercloud. We should have a check that the file exists if we detect that an installation was previously run.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/481122

[Marios Andreou (marios-b)]

also discussed here https://bugzilla.redhat.com/show_bug.cgi?id=1468174

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481122
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=74123de347437e6953429f27ab1a89adcf8ac085
Submitter: Jenkins
Branch: master

commit 74123de347437e6953429f27ab1a89adcf8ac085
Author: Ben Nemec <email address hidden>
Date: Thu Jul 6 15:49:08 2017 +0000

    Fail-fast if the undercloud-passwords.conf file is missing

    On undercloud updates/upgrades, if the undercloud-passwords.conf
    file was deleted or moved it will break some services because there
    are passwords that cannot be changed. This validates that the file
    exists and stops immediately with a message explaining the problem
    if the file is missing.

    Change-Id: Ic83d6afc8dc2128874b97cc414ea28272e7d6639
    Closes-Bug: 1702709

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/483508

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/483508
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=b86f03e3b5ac82ce8b6a92a07116647cfdf6cd79
Submitter: Jenkins
Branch: stable/ocata

commit b86f03e3b5ac82ce8b6a92a07116647cfdf6cd79
Author: Ben Nemec <email address hidden>
Date: Thu Jul 6 15:49:08 2017 +0000

    Fail-fast if the undercloud-passwords.conf file is missing

    On undercloud updates/upgrades, if the undercloud-passwords.conf
    file was deleted or moved it will break some services because there
    are passwords that cannot be changed. This validates that the file
    exists and stops immediately with a message explaining the problem
    if the file is missing.

    Change-Id: Ic83d6afc8dc2128874b97cc414ea28272e7d6639
    Closes-Bug: 1702709
    (cherry picked from commit 74123de347437e6953429f27ab1a89adcf8ac085)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/484482

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/484482
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=e9a5137e7e4c0f88c9cb44e60d311a7604470652
Submitter: Jenkins
Branch: stable/newton

commit e9a5137e7e4c0f88c9cb44e60d311a7604470652
Author: Ben Nemec <email address hidden>
Date: Thu Jul 6 15:49:08 2017 +0000

    Fail-fast if the undercloud-passwords.conf file is missing

    On undercloud updates/upgrades, if the undercloud-passwords.conf
    file was deleted or moved it will break some services because there
    are passwords that cannot be changed. This validates that the file
    exists and stops immediately with a message explaining the problem
    if the file is missing.

    Change-Id: Ic83d6afc8dc2128874b97cc414ea28272e7d6639
    Closes-Bug: 1702709
    (cherry picked from commit 74123de347437e6953429f27ab1a89adcf8ac085)
    (cherry picked from commit b86f03e3b5ac82ce8b6a92a07116647cfdf6cd79)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 7.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 5.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 6.1.1 release.