CI: Undercloud containers job timing out

[Steve Baker]

It times out possibly on creating the server resource
http://logs.openstack.org/34/477234/1/check/gate-tripleo-ci-centos-7-undercloud-containers-nv/92ac1d0/logs/var/log/undercloud_install.txt.gz

It looks like it is caused by this change landing https://review.openstack.org/#/c/475750/1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/477244

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/477254

[Steve Baker (steve-stevebaker)]

Current attempt to fix is https://review.openstack.org/#/c/477254/ but it is still timing out for me locally with these resources timing out:

undercloud.Undercloud.0.Undercloud.HostsEntryDeployment
undercloud.Undercloud.0.Undercloud.UpgradeInitDeployment

I'm going to mark as unassigned so someone else can pick this up during my overnight, I'll look again tomorrow.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steve Baker (<email address hidden>) on branch: master
Review: https://review.openstack.org/477244

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/477710

[Steve Baker (steve-stevebaker)]

I believe https://review.openstack.org/#/c/477710/ will fix this

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steve Baker (<email address hidden>) on branch: master
Review: https://review.openstack.org/477254

[Steven Hardy (shardy)]

Looking at why this happened, it seems that:

https://github.com/openstack/tripleo-heat-templates/commit/ef82c3a010cf6161f1da1020698dbd38257f5a12

Was supposed to convert role.role.j2.yaml to use the role specific type, but because it had a syntax error (role.name vs role) that is somehow ignored when rendering the undercloud-role.yaml via process-templates.yaml, which meant the {{role.name}} was ignored, so the rendered type was the same as the old OS::TripleO::Server

An error is apparently raised when doing overcloud deployments with custom roles (which should have broken the 3nodes job?) which was fixed in:

https://github.com/openstack/tripleo-heat-templates/commit/94592cab5b013196456adb596ce241f4d14e2e78

At that point the type name changed in the output template from process-templates.py, which broke the undercloud job.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/477710
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=4b1daab4eb7e29dafabc68ed82a3022399cbe013
Submitter: Jenkins
Branch: master

commit 4b1daab4eb7e29dafabc68ed82a3022399cbe013
Author: Steve Baker <email address hidden>
Date: Mon Jun 26 23:34:44 2017 +0000

    Undercloud install, find the right server resource

    The deployed-server resource for the undercloud will now have the
    role-specific type OS::TripleO::UndercloudServer, so the logic to set
    up the os-collect-config config needs to check for this type as well
    as OS::TripleO::Server

    This will help, and may be all that is required to unbreak the
    undercloud containers CI.

    Change-Id: Ie6f8012ecca66dc8a563026304188850ed9c9378
    Closes-Bug: #1700417

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 7.2.0 release.