Could not fetch contents for file:///tmp/tripleoclient-LdqQGJ/tripleo-heat-templates/network/internalapi.yaml

[Michele Baldessari]

This morning when redeploying my usual setup with netiso from master I got the following error:
+ openstack overcloud deploy --templates /home/stack/tripleo-heat-templates --libvirt-type qemu --control-flavor oooq_control --compute-flavor oooq_compute --ceph-storage-flavor oooq_ceph --block-storage-flavor oooq_blockstorage --swift-storage-flavor oooq_objectstorage --timeout 90 -e /home/stack/cloud-names.yaml -e /home/stack/tripleo-heat-templates/environments/network-isolation.yaml -e /home/stack/tripleo-heat-templates/environments/net-single-nic-with-vlans.yaml -e /home/stack/network-environment.yaml -e /home/stack/tripleo-heat-templates/environments/low-memory-usage.yaml -e /home/stack/tripleo-heat-templates/environments/disable-telemetry.yaml --compute-scale 3 --control-scale 3 --ntp-server pool.ntp.org --no-cleanup -e /home/stack/tripleo-heat-templates/environments/config-debug.yaml -e /home/stack/tripleo-heat-templates/environments/docker.yaml -e /home/stack/tripleo-heat-templates/environments/docker-ha.yaml -e /home/stack/custom-stuff.yaml -r /home/stack/custom_roles.yaml
Waiting for messages on queue '005b9390-ee1f-406b-b9aa-54eb534ce1d7' with no timeout.
Not cleaning temporary directory /tmp/tripleoclient-LdqQGJ
Could not fetch contents for file:///tmp/tripleoclient-LdqQGJ/tripleo-heat-templates/network/internalapi.yaml
Started Mistral Workflow tripleo.validations.v1.check_pre_deployment_validations. Execution ID: 79ecb3a8-210d-45be-b9c8-5a588a0a979c

I think the change If3989f24f077738845d2edbee405bd9198e7b7db is what is breaking my current setup.
We have the following line at https://github.com/openstack/tripleo-heat-templates/blob/master/environments/network-isolation.j2.yaml#L16:

 {%- for network in networks if network.enabled|default(true) %}
  OS::TripleO::Network::{{network.name}}: ../network/{{network.name.lower()}}.yaml
 {%- endfor %}

But in network_data.yaml we have the following:
- name: InternalApi
  name_lower: internal_api
  vip: true

We should probably reference network.name_lower and not network.name.lower()

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/474100

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/474100
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=47a9472c88d8f1ce0a335aca41110fb78e27bc16
Submitter: Jenkins
Branch: master

commit 47a9472c88d8f1ce0a335aca41110fb78e27bc16
Author: Michele Baldessari <email address hidden>
Date: Wed Jun 14 10:07:48 2017 +0200

    Fix network names when using network isolation

    When we merged If3989f24f077738845d2edbee405bd9198e7b7db we correctly
    used name_lower for most things but we left out the the
    OS::TripleO::Network resource which would cause errors like the
    following:

    Could not fetch contents for file:///tmp/tripleoclient-LdqQGJ/tripleo-heat-templates/network/internalapi.yaml

    The reason is that the network filename is called internal_api.yaml.

    Change-Id: I40f268668ed948e5d41ed0ff5a8fc954cef7b17c
    Closes-Bug: #1697883

[Alan Pevec (apevec)]

@bandini @shardy
This was also hit in RDO CI promotion https://ci.centos.org/artifacts/rdo/jenkins-tripleo-quickstart-promote-master-current-tripleo-delorean-minimal-216/undercloud/home/stack/overcloud_deploy.log.gz

According to https://github.com/openstack-infra/tripleo-ci/blob/master/README.rst#feature-testing-matrix network isolation should have been covered by ovb-ha job and in https://review.openstack.org/409920 gate-tripleo-ci-centos-7-ovb-ha-oooq did pass.
That means toci coverage is missing parts of THT, seems that templates in tripleo-ci/test-environments/ are not triggering THT environments/network-isolation.j2.yaml ?

[Alan Pevec (apevec)]

Tracking preventive action to increase THT gate coverage in https://trello.com/c/bOvCBjGd/184-tht-lp1697883-tht-gate-coverage-for-network-isolation

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b3 development milestone.