Using Ironic in the overcloud now requires cell host discovery on each node creation

[Dmitry Tantsur]

Starting with the Ocata release, nodes enrolled in Ironic are not picked by Nova automatically. We have to either recommend users to run a command on controllers or enable a periodic task to run it. I guess the latter is more in spirit of an installer like TripleO.

Also, when enrolling nodes, we randomly pick the controller which is assigned to "manage" it. For instance, when adding a node the first time, it gets assigned controller-1. If you delete and re-add it, then controller-2 is selected. This can be seen by executing a "nova hypervisor show" against the baremetal compute node listed in the "nova hypervisor list".
The nova-manage command looks at the environment at the time you run the nova-manage command and ONLY includes the Ironic nodes that have baremetal servers it is managing.

The plan is as follows:
1. expose scheduler discover_hosts_in_cells_interval option in puppet-nova (keeping the default),
2. document setting it to 30 (15?) for a bare metal deployment.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/473890

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/473896

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/473890
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=8c8d795067b5a09d029a263683d35e15a8c43b37
Submitter: Jenkins
Branch: master

commit 8c8d795067b5a09d029a263683d35e15a8c43b37
Author: Dmitry Tantsur <email address hidden>
Date: Tue Jun 13 17:53:50 2017 +0200

    Expose nova::scheduler::discover_hosts_in_cells_interval option

    Starting with the Ocata release, bare metal nodes are no longer get recognized
    by nova automatically. To avoid forcing users into running nova manage command
    each time they enroll a node, we will have to allow enable the periodic task
    to do so. This option configures it.

    Change-Id: I1f0e40474018de593cb3f8798b5212285f5629a4
    Closes-Bug: #1697724

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/474133

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/474133
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=ef267d195231f6cd3f5bcd4c15b4d196338a88b4
Submitter: Jenkins
Branch: stable/ocata

commit ef267d195231f6cd3f5bcd4c15b4d196338a88b4
Author: Dmitry Tantsur <email address hidden>
Date: Tue Jun 13 17:53:50 2017 +0200

    Expose nova::scheduler::discover_hosts_in_cells_interval option

    Starting with the Ocata release, bare metal nodes are no longer get recognized
    by nova automatically. To avoid forcing users into running nova manage command
    each time they enroll a node, we will have to allow enable the periodic task
    to do so. This option configures it.

    Change-Id: I1f0e40474018de593cb3f8798b5212285f5629a4
    Closes-Bug: #1697724
    (cherry picked from commit 8c8d795067b5a09d029a263683d35e15a8c43b37)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/473896
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f0807b535b0cff5eac82fdaa9719650f79839c15
Submitter: Jenkins
Branch: master

commit f0807b535b0cff5eac82fdaa9719650f79839c15
Author: Dmitry Tantsur <email address hidden>
Date: Tue Jun 13 18:05:33 2017 +0200

    Enable periodic task to discover cell hosts when ironic is used

    Starting with the Ocata release, bare metal nodes are no longer get recognized
    by nova automatically. To avoid forcing users into running nova manage command
    each time they enroll a node, we will have to allow enable the periodic task
    to do so.

    Change-Id: I8b0afac54dc9bd51dbe2ae4f237e4de50459be0f
    Closes-Bug: #1697724

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/477084

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/477084
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=97c3806ccf1f5f38eeedcbea6524571b8b3ef040
Submitter: Jenkins
Branch: stable/ocata

commit 97c3806ccf1f5f38eeedcbea6524571b8b3ef040
Author: Dmitry Tantsur <email address hidden>
Date: Tue Jun 13 18:05:33 2017 +0200

    Enable periodic task to discover cell hosts when ironic is used

    Starting with the Ocata release, bare metal nodes are no longer get recognized
    by nova automatically. To avoid forcing users into running nova manage command
    each time they enroll a node, we will have to allow enable the periodic task
    to do so.

    Change-Id: I8b0afac54dc9bd51dbe2ae4f237e4de50459be0f
    Closes-Bug: #1697724
    (cherry picked from commit f0807b535b0cff5eac82fdaa9719650f79839c15)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 11.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/489228

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/489228
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=17804c7740f9a6ee0567c1983c8e2d46426207d4
Submitter: Jenkins
Branch: master

commit 17804c7740f9a6ee0567c1983c8e2d46426207d4
Author: Dmitry Tantsur <email address hidden>
Date: Mon Jul 31 15:47:23 2017 +0200

    Copy scheduler configuration from service/ironic to services-docker/ironic

    That was missed back then. Without it bug 1697724 is not fixed for containers.

    Change-Id: Ie859f10129cbdeebd9ea4522510768cec99a1df3
    Related-Bug: #1697724

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 10.5.0 release.