overcloud deploy --environment-directory doesn't warn if the environment directory doesn't exist

Bug #1697031 reported by Matthew Booth on 2017-06-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Medium
Ana Krivokapić

Bug Description

$SUBJECT says it all. Earlier I typod the environment directory, and I only noticed when the deploy finished and I realised it had no customisations. Cursing was involved. I'd have preferred to be told up front and fix the typo.

This was specifically using tripleo client from OSP10.

Changed in tripleo:
status: New → Triaged
milestone: none → pike-3
importance: Undecided → Medium
Julie Pichon (jpichon) on 2017-06-19
Changed in tripleo:
assignee: nobody → Julie Pichon (jpichon)
tags: added: tripleoclient

Fix proposed to branch: master
Review: https://review.openstack.org/475442

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
assignee: Julie Pichon (jpichon) → Ana Krivokapić (akrivoka)
Changed in tripleo:
milestone: pike-3 → pike-rc1
Changed in tripleo:
milestone: pike-rc1 → queens-1

Reviewed: https://review.openstack.org/475442
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=7efe0f12c3e65606125b90ed4932c3214a15256a
Submitter: Jenkins
Branch: master

commit 7efe0f12c3e65606125b90ed4932c3214a15256a
Author: Julie Pichon <email address hidden>
Date: Mon Jun 19 16:06:26 2017 +0100

    Fail early in case of error in env directory path

    Specified environment directories were silently ignored if they didn't
    exist, meaning a typo in a path argument might only be discovered very
    late, after the deployment finishes.

    The ~/.tripleo/environment special case is preserved, and will still be
    silently ignored when not present.

    Change-Id: I33760ef3f5ce04209ddaf06fb5522eb8375e4385
    Closes-Bug: #1697031

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/python-tripleoclient 8.0.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers