Unsuitable error when supplying an invalid instackenv.json

Bug #1693442 reported by Itzik Brown
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Jehoszafat Zimnowoda

Bug Description

When running openstack overcloud node import instackenv.json with the following file I get: No JSON object could be decoded
{
    "nodes":[
        {
            "name": "controller-0",
            "mac":[
                "98:42:ab:a6:13:a2"
            ],
            "cpu":"18",
            "memory":"40000",
            "disk":"100",
            "arch":"x86_64",
            "pm_type":"pxe_ipmitool",
            "pm_user":"myuser",
            "pm_password":"mypassword",
            "pm_addr":"192.168.150.1"
        },
        {
            "name": "compute-0",
            "mac":[
                "98:42:ab:a6:13:1c"
            ],
            "cpu":"18",
            "memory":"40000",
            "disk":"100",
            "arch":"x86_64",
            "pm_type":"pxe_ipmitool",
            "pm_user":"myuser",
            "pm_password":"mypassword",
            "pm_addr":"192.168.150.2",
            "capabilities":"node:compute,boot_option:local"
        },
    ]
}

I expect the command to parse the file and tell where the error is.

summary: - Unsuitable error when suppying an invalid instackenv.json
+ Unsuitable error when supplying an invalid instackenv.json
Changed in tripleo:
status: New → Triaged
importance: Undecided → Medium
milestone: none → pike-3
Changed in tripleo:
assignee: nobody → j.zimnowoda (j-zimnowoda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/470776

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
milestone: pike-3 → pike-rc1
Changed in tripleo:
milestone: pike-rc1 → queens-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/470776
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=b60d221fe1b18b155066c93f62df7bef7013168a
Submitter: Jenkins
Branch: master

commit b60d221fe1b18b155066c93f62df7bef7013168a
Author: Jehoszafat Zimnowoda <email address hidden>
Date: Sun Jun 4 20:33:17 2017 +0200

    Use simplejson to load json file

    The simplejson extends json library. It provides sufficient information about
    JSON syntax errors, which often occurs during instackenv.json file creation.

    Change-Id: Ied1c080678af728820e02b7b99c51762b49b1449
    Closes-Bug: #1693442
    Depends on external: https://review.rdoproject.org/r/#/c/7872/

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 8.0.0

This issue was fixed in the openstack/python-tripleoclient 8.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.