revenge of the tuskar - remove left over packages if present after upgrade

[Marios Andreou]

As first discussed at https://bugzilla.redhat.com/show_bug.cgi?id=1324894 and https://bugzilla.redhat.com/show_bug.cgi?id=1353346 if you have a tripleo deployment that started at Kilo when tuskar was still in use the left-over package can cause problems during subsequent upgrades.

We can either add this to the tripleo-client (here https://github.com/openstack/python-tripleoclient/blob/78d468884200e862d81faceb4629ff0ea1c94b67/tripleoclient/v1/undercloud.py#L50-L52 after this for example) or into instack-undercloud to happen during the instack install/upgrade undercloud invocation.

Posting something momentarily that does the latter. I think we should backport this as far as we can, stable/newton currently.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/465940

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465940
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=2114ee63ae8e63d8ddafaa64f6bb0b6bae9c9db9
Submitter: Jenkins
Branch: master

commit 2114ee63ae8e63d8ddafaa64f6bb0b6bae9c9db9
Author: marios <email address hidden>
Date: Thu May 18 15:21:31 2017 +0300

    Remove any left-over tuskar packages on upgrade

    During the instack install/upgrade undercloud run remove any
    left over packages - see bug for more info

    Closes-Bug: 1691744
    Change-Id: I25dcdd82803f51db456213751849443715c8fe6f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/466605

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466605
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=7cbdf710a768dc4035da51465b75e276dc7bcee3
Submitter: Jenkins
Branch: stable/ocata

commit 7cbdf710a768dc4035da51465b75e276dc7bcee3
Author: marios <email address hidden>
Date: Thu May 18 15:21:31 2017 +0300

    Remove any left-over tuskar packages on upgrade

    During the instack install/upgrade undercloud run remove any
    left over packages - see bug for more info

    Closes-Bug: 1691744
    Change-Id: I25dcdd82803f51db456213751849443715c8fe6f
    (cherry picked from commit 2114ee63ae8e63d8ddafaa64f6bb0b6bae9c9db9)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/466797

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/466798

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466798
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=798dfdc0dd6525e2e367c011794bd46f54c4398f
Submitter: Jenkins
Branch: master

commit 798dfdc0dd6525e2e367c011794bd46f54c4398f
Author: marios <email address hidden>
Date: Mon May 22 18:47:07 2017 +0300

    Add unit test and release note for tuskar package removal

    In I25dcdd82803f51db456213751849443715c8fe6f we added explicit
    removal of tuskar for the related bug below. This change adds
    basic test and release note as requested at
    https://review.openstack.org/#/c/466605/

    Change-Id: I77cb4a1bf5cb880505e2f6dfefcf06d79eab23b3
    Related-Bug: 1691744

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ocata
Review: https://review.openstack.org/467617

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/467617
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=dca0042eb0c02f1a302d34ba691a63d1f7d7a6a4
Submitter: Jenkins
Branch: stable/ocata

commit dca0042eb0c02f1a302d34ba691a63d1f7d7a6a4
Author: marios <email address hidden>
Date: Mon May 22 18:47:07 2017 +0300

    Add unit test and release note for tuskar package removal

    In I25dcdd82803f51db456213751849443715c8fe6f we added explicit
    removal of tuskar for the related bug below. This change adds
    basic test and release note as requested at
    https://review.openstack.org/#/c/466605/

    Change-Id: I77cb4a1bf5cb880505e2f6dfefcf06d79eab23b3
    Related-Bug: 1691744
    (cherry picked from commit 798dfdc0dd6525e2e367c011794bd46f54c4398f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466797
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=a99caeb061588041544283f54e4b053bfe62f266
Submitter: Jenkins
Branch: stable/newton

commit a99caeb061588041544283f54e4b053bfe62f266
Author: marios <email address hidden>
Date: Thu May 18 15:21:31 2017 +0300

    Remove any left-over tuskar packages on upgrade

    During the instack install/upgrade undercloud run remove any
    left over packages - see bug for more info. This cherrypick
    is slightly different from ocata because here we don't have
    the 'is upgrade' check/fact so we run the tuskar removal on
    every instack run.

    Closes-Bug: 1691744
    Change-Id: I25dcdd82803f51db456213751849443715c8fe6f
    (cherry picked from commit 7cbdf710a768dc4035da51465b75e276dc7bcee3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 7.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 5.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 6.1.1 release.