undercloud masquerading hardcoded to eth0

[Harald Jensås]

Masquerading is hardcoded to eth0.

a) This will not work on hardware that uses predictable network interface names.
b) Why is the entry in L13 even there?
   Any traffic we want to be masqueraded will be masqueraded in BOOTSTACK_MASQ_NEW? (ref L12 below)

File: instack-undercloud/elements/undercloud-install/os-apply-config/var/opt/undercloud-stack/masquerade

      7 # Build the chain we want.
      8 {{#masquerade_networks}}
      9 NETWORK={{.}}
     10 # Workaround iptables not permitting two -d parameters in one call.
     11 iptables -w -t nat -A BOOTSTACK_MASQ_NEW -s $NETWORK -d 192.168.122.1 -j RETURN
     12 iptables -w -t nat -A BOOTSTACK_MASQ_NEW -s $NETWORK ! -d $NETWORK -j MASQUERADE
     13 iptables -w -t nat -A POSTROUTING -s $NETWORK -o eth0 -j MASQUERADE
     14 {{/masquerade_networks}}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/464339

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464339
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=333ca292fc0ea0945af3b35f5ca7e240a5902d92
Submitter: Jenkins
Branch: master

commit 333ca292fc0ea0945af3b35f5ca7e240a5902d92
Author: Harald Jensas <email address hidden>
Date: Sun May 14 16:55:50 2017 +0200

    Remove hardcoded eth0 MASQUERADE rule

    Any data that should be masqueraded will be masqueraded
    by the following rule which is earlier in the chain.

      iptables -t nat-A BOOTSTACK_MASQ_NEW -s $NETWORK ! -d $NETWORK -j MASQUERADE

    Closes-Bug: #1690584
    Change-Id: Ic30b24959ca3259974160abcfa213e6a14c953f5

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 7.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/556563

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/556564

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/556563
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=2849da2b6f8e3095eda2e8c7f311f8ae207a7c3c
Submitter: Zuul
Branch: stable/ocata

commit 2849da2b6f8e3095eda2e8c7f311f8ae207a7c3c
Author: Harald Jensas <email address hidden>
Date: Sun May 14 16:55:50 2017 +0200

    Remove hardcoded eth0 MASQUERADE rule

    Any data that should be masqueraded will be masqueraded
    by the following rule which is earlier in the chain.

      iptables -t nat-A BOOTSTACK_MASQ_NEW -s $NETWORK ! -d $NETWORK -j MASQUERADE

    Closes-Bug: #1690584
    Change-Id: Ic30b24959ca3259974160abcfa213e6a14c953f5
    (cherry picked from commit 333ca292fc0ea0945af3b35f5ca7e240a5902d92)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/556564
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=a48f3a8ed653b1c307b774c868044be1c614a901
Submitter: Zuul
Branch: stable/newton

commit a48f3a8ed653b1c307b774c868044be1c614a901
Author: Harald Jensas <email address hidden>
Date: Sun May 14 16:55:50 2017 +0200

    Remove hardcoded eth0 MASQUERADE rule

    Any data that should be masqueraded will be masqueraded
    by the following rule which is earlier in the chain.

      iptables -t nat-A BOOTSTACK_MASQ_NEW -s $NETWORK ! -d $NETWORK -j MASQUERADE

    Closes-Bug: #1690584
    Change-Id: Ic30b24959ca3259974160abcfa213e6a14c953f5
    (cherry picked from commit 333ca292fc0ea0945af3b35f5ca7e240a5902d92)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 6.1.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 5.3.9 release.