"openstack baremetal introspection bulk status" fails when any node was not introspected

Bug #1689540 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
Dmitry Tantsur

Bug Description

Currently it tries to fetch status for all nodes. If any of them was never introspected at all (e.g. it's in maintenance mode), the command fails with "Could not find node <UUID> in cache". We should skip such nodes with a reasonable message instead.

Originally filed as https://bugzilla.redhat.com/show_bug.cgi?id=1404902. Reproducible on all supported versions.

Dmitry Tantsur (divius)
tags: added: newton-backport-potential ocata-backport-potential tripleoclient
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/463549

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/463549
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=759dff71d892fcf21ee841cd0a8aee837b519f76
Submitter: Jenkins
Branch: master

commit 759dff71d892fcf21ee841cd0a8aee837b519f76
Author: Dmitry Tantsur <email address hidden>
Date: Tue May 9 14:01:10 2017 +0200

    Fix 'introspection bulk status' when some nodes were never introspected

    Previously we did not handle exceptions from ironic_inspector_client, so nodes
    that were never introspected (e.g. ones in maintenance mode) caused this
    command to fail.

    Change-Id: I58756256fe70992ff5618a3f307ce34f95e71efd
    Closes-Bug: #1689540

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/467935

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/468002

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/ocata)

Reviewed: https://review.openstack.org/467935
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=7622ea3519636edf18f0e4b59a97ef649397bccf
Submitter: Jenkins
Branch: stable/ocata

commit 7622ea3519636edf18f0e4b59a97ef649397bccf
Author: Dmitry Tantsur <email address hidden>
Date: Tue May 9 14:01:10 2017 +0200

    Fix 'introspection bulk status' when some nodes were never introspected

    Previously we did not handle exceptions from ironic_inspector_client, so nodes
    that were never introspected (e.g. ones in maintenance mode) caused this
    command to fail.

    Change-Id: I58756256fe70992ff5618a3f307ce34f95e71efd
    Closes-Bug: #1689540
    (cherry picked from commit 759dff71d892fcf21ee841cd0a8aee837b519f76)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/newton)

Reviewed: https://review.openstack.org/468002
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=03abd22cba170a569ed50e1ff25c127b5a479d20
Submitter: Jenkins
Branch: stable/newton

commit 03abd22cba170a569ed50e1ff25c127b5a479d20
Author: Dmitry Tantsur <email address hidden>
Date: Tue May 9 14:01:10 2017 +0200

    Fix 'introspection bulk status' when some nodes were never introspected

    Previously we did not handle exceptions from ironic_inspector_client, so nodes
    that were never introspected (e.g. ones in maintenance mode) caused this
    command to fail.

    Change-Id: I58756256fe70992ff5618a3f307ce34f95e71efd
    Closes-Bug: #1689540
    (cherry picked from commit 759dff71d892fcf21ee841cd0a8aee837b519f76)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 7.1.0

This issue was fixed in the openstack/python-tripleoclient 7.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 5.4.3

This issue was fixed in the openstack/python-tripleoclient 5.4.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 6.2.1

This issue was fixed in the openstack/python-tripleoclient 6.2.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.