puppet runs needlessly when scaling roles

Bug #1688387 reported by James Slagle on 2017-05-04
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tripleo
High
James Slagle
Newton
Undecided
Unassigned
Ocata
Undecided
Unassigned

Bug Description

When you scale a role, such as a compute, puppet runs on all nodes in the deployment due to the unique DeployIdentifier set in tripleo-common. Often, this is unnecessary. When scaling some roles it is necessary, or for controller replacement.

We added the ability to pass --skip-deploy-identifier so the user could indicate when they knew not to set a unique DeployIdentifier, and this results in a much faster compute scale out time, and prevents puppet from running across all your controllers.

I'm filing this bug so we can track backporting the --skip-deploy-identifier patches to Ocata.

Changed in tripleo:
importance: Undecided → High
milestone: none → pike-2
assignee: nobody → James Slagle (james-slagle)
tags: added: idempotency
Changed in tripleo:
status: New → Triaged

Reviewed: https://review.openstack.org/462723
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=320960c804fcdcaa1458a7dec1fbbe70f77900ee
Submitter: Jenkins
Branch: stable/ocata

commit 320960c804fcdcaa1458a7dec1fbbe70f77900ee
Author: James Slagle <email address hidden>
Date: Fri Mar 31 16:13:52 2017 -0400

    Add skip_deploy_identifier

    Add a new action argument, skip_deploy_identifier to DeployStackAction.
    The argument will disable setting a unique value for the
    DeployIdentifier parameter, which means the SoftwareDeployment resources
    in the templates will only be triggered if there is an actual change to
    their configuration. This argument can be used to avoid always applying
    configuration, such as during node scale out.

    Change-Id: Idb901a841846fec33d189b3c95f669b0380498ce
    Closes-Bug: #1688387
    (cherry picked from commit 9d158874301eaa9444811f2c21cc9d86c2eaad7a)

tags: added: in-stable-ocata

Reviewed: https://review.openstack.org/462724
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=1b877698ce76f858d6d9d0dc629261bf21aa89f9
Submitter: Jenkins
Branch: stable/ocata

commit 1b877698ce76f858d6d9d0dc629261bf21aa89f9
Author: James Slagle <email address hidden>
Date: Fri Mar 31 10:24:32 2017 -0400

    Add --skip-deploy-identifier

    Add a new cli argument, --skip-deploy-identifier. The argument will
    eventually be passed to the tripleo-common DeployStackAction action to
    disable setting a unique value for the DeployIdentifier parameter, which
    means the SoftwareDeployment resources in the templates will only be
    triggered if there is an actual change to their configuration. This
    argument can be used to avoid always applying configuration, such as
    during node scale out.

    Removes the setting of DeployIdentifier completely from tripleoclient,
    as that is now handled by the tripleo-common action.

    Depends-On: Idb901a841846fec33d189b3c95f669b0380498ce
    Change-Id: I294eabe84e070367981534030b5927062f00c628
    Closes-Bug: #1688387
    (cherry picked from commit f3acb69ffce3c630df5b3051779a7af21b96af47)

Changed in tripleo:
milestone: pike-2 → pike-3
Emilien Macchi (emilienm) wrote :

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

Changed in tripleo:
assignee: James Slagle (james-slagle) → nobody
Changed in tripleo:
milestone: pike-3 → pike-rc1
Changed in tripleo:
assignee: nobody → James Slagle (james-slagle)
tags: added: ocata-backport-potential
tags: added: newton-backport-potential

Reviewed: https://review.openstack.org/489813
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=de872dd3dec645b853d86f0a8e6751efd1ae3b0d
Submitter: Jenkins
Branch: stable/newton

commit de872dd3dec645b853d86f0a8e6751efd1ae3b0d
Author: James Slagle <email address hidden>
Date: Fri Mar 31 16:13:52 2017 -0400

    Add skip_deploy_identifier

    Add a new action argument, skip_deploy_identifier to DeployStackAction.
    The argument will disable setting a unique value for the
    DeployIdentifier parameter, which means the SoftwareDeployment resources
    in the templates will only be triggered if there is an actual change to
    their configuration. This argument can be used to avoid always applying
    configuration, such as during node scale out.

    Change-Id: Idb901a841846fec33d189b3c95f669b0380498ce
    Closes-Bug: #1688387
    (cherry picked from commit 9d158874301eaa9444811f2c21cc9d86c2eaad7a)
    (cherry picked from commit 320960c804fcdcaa1458a7dec1fbbe70f77900ee)

tags: added: in-stable-newton

Reviewed: https://review.openstack.org/489812
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=d98fff454bcc8a7a7aa124452a68384cffa43b9a
Submitter: Jenkins
Branch: stable/newton

commit d98fff454bcc8a7a7aa124452a68384cffa43b9a
Author: James Slagle <email address hidden>
Date: Fri Mar 31 10:24:32 2017 -0400

    Add --skip-deploy-identifier

    Add a new cli argument, --skip-deploy-identifier. The argument will
    eventually be passed to the tripleo-common DeployStackAction action to
    disable setting a unique value for the DeployIdentifier parameter, which
    means the SoftwareDeployment resources in the templates will only be
    triggered if there is an actual change to their configuration. This
    argument can be used to avoid always applying configuration, such as
    during node scale out.

    Removes the setting of DeployIdentifier completely from tripleoclient,
    :xa
    git

    as that is now handled by the tripleo-common action.

    Depends-On: Idb901a841846fec33d189b3c95f669b0380498ce
    Change-Id: I294eabe84e070367981534030b5927062f00c628
    Closes-Bug: #1688387
    (cherry picked from commit f3acb69ffce3c630df5b3051779a7af21b96af47)
    (cherry picked from commit 1b877698ce76f858d6d9d0dc629261bf21aa89f9)

Ben Nemec (bnemec) wrote :

Since the newton fixes only landed a couple of days ago, Fix Released is probably not entirely accurate for that branch. I'm not sure whether the bot will update properly since the bug wasn't targeted to newton though.

Changed in tripleo:
status: Triaged → Fix Released

This issue was fixed in the openstack/python-tripleoclient 5.4.3 release.

This issue was fixed in the openstack/tripleo-common 5.4.3 release.

This issue was fixed in the openstack/python-tripleoclient 6.2.1 release.

This issue was fixed in the openstack/tripleo-common 6.1.1 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers