tripleoclient in workflows/base.py in the call_action method does not check if the action passed or failed. It just assumes it succeeded and returns the output. In particular, the overcloudrc create action can fall and the error is not handled, resulting in utils.write_overcloudrc treading the error message as a dict of overclodurc values.
which then fails with a cryptic error:
"string indices must be intergers"
full traceback:
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/osc_lib/shell.py", line 135, in run
ret_val = super(OpenStackShell, self).run(argv)
File "/usr/lib/python2.7/site-packages/cliff/app.py", line 279, in run
result = self.run_subcommand(remainder)
File "/usr/lib/python2.7/site-packages/osc_lib/shell.py", line 180, in run_subcommand
ret_value = super(OpenStackShell, self).run_subcommand(argv)
File "/usr/lib/python2.7/site-packages/cliff/app.py", line 400, in run_subcommand
result = cmd.run(parsed_args)
File "/usr/lib/python2.7/site-packages/osc_lib/command/command.py", line 41, in run
return super(Command, self).run(parsed_args)
File "/usr/lib/python2.7/site-packages/cliff/command.py", line 90, in run
return self.take_action(parsed_args) or 0
File "/usr/lib/python2.7/site-packages/tripleoclient/v1/overcloud_deploy.py", line 898, in take_action
utils.write_overcloudrc(stack.stack_name, overcloudrcs)
File "/usr/lib/python2.7/site-packages/tripleoclient/utils.py", line 73, in write_overcloudrc
rcfile.write(overcloudrcs['overcloudrc'])
TypeError: string indices must be integers
Fix proposed to branch: master
Review: https:/