upgrades CI error ControllerPostPuppetMaintenanceModeDeployment

[Steven Hardy]

Seeing this:

2017-04-26 14:08:51.017878 | 2017-04-26 14:08:46Z [overcloud.AllNodesDeploySteps.ControllerPostConfig.ControllerPostPuppetMaintenanceModeDeployment]: CREATE_IN_PROGRESS state changed
2017-04-26 14:08:51.017973 | 2017-04-26 14:08:47Z [overcloud.AllNodesDeploySteps.ControllerPostConfig.ControllerPostPuppetMaintenanceModeDeployment]: CREATE_FAILED resources.ControllerPostPuppetMaintenanceModeDeployment: Property error: resources.Controller.properties.server: Value must be a string
2017-04-26 14:08:51.018052 | 2017-04-26 14:08:47Z [overcloud.AllNodesDeploySteps.ControllerPostConfig]: CREATE_FAILED Resource CREATE failed: resources.ControllerPostPuppetMaintenanceModeDeployment: Property error: resources.Controller.properties.server: Value must be a string
2017-04-26 14:08:51.018132 | 2017-04-26 14:08:47Z [overcloud.AllNodesDeploySteps.ControllerPostConfig]: CREATE_FAILED resources.ControllerPostPuppetMaintenanceModeDeployment: resources.ControllerPostConfig.Property error: resources.Controller.properties.server: Value must be a string
2017-04-26 14:08:51.018232 | 2017-04-26 14:08:47Z [overcloud.AllNodesDeploySteps]: CREATE_FAILED Resource CREATE failed: resources.ControllerPostPuppetMaintenanceModeDeployment: resources.ControllerPostConfig.Property error: resources.Controller.properties.server: Value must be a string
2017-04-26 14:08:51.018326 | 2017-04-26 14:08:47Z [overcloud.AllNodesDeploySteps]: CREATE_FAILED resources.ControllerPostPuppetMaintenanceModeDeployment: resources.AllNodesDeploySteps.resources.ControllerPostConfig.Property error: resources.Controller.properties.server: Value must be a string
2017-04-26 14:08:51.018411 | 2017-04-26 14:08:48Z [overcloud]: CREATE_FAILED Resource CREATE failed: resources.ControllerPostPuppetMaintenanceModeDeployment: resources.AllNodesDeploySteps.resources.ControllerPostConfig.Property error: resources.Controller.properties.server: Value must be a string
2017-04-26 14:08:51.018441 |
2017-04-26 14:08:51.018460 | Stack overcloud CREATE_FAILED
2017-04-26 14:08:51.018469 |
2017-04-26 14:08:57.135250 | overcloud.AllNodesDeploySteps.ControllerPostConfig.ControllerPostPuppetMaintenanceModeDeployment:
2017-04-26 14:08:57.135330 | resource_type: OS::Heat::SoftwareDeployments
2017-04-26 14:08:57.135363 | physical_resource_id:
2017-04-26 14:08:57.135400 | status: CREATE_FAILED
2017-04-26 14:08:57.135415 | status_reason: |
2017-04-26 14:08:57.135463 | resources.ControllerPostPuppetMaintenanceModeDeployment: Property error: resources.Controller.properties.server: Value must be a string
2017-04-26 14:08:57.148870 | Heat Stack create failed.
2017-04-26 14:08:57.148935 | Heat Stack create failed.
2017-04-26 14:08:57.206969 | #################
2017-04-26 14:08:57.207036 | tripleo.sh -- Overcloud create - FAILED!

Looks like a template issue (missing fix on ocata?) but I've not found where yet

[Carlos Camacho (ccamacho)]

Fix proposed: https://review.openstack.org/#/c/460457/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/460457
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=77b4bd53dae1882ae3094597e674218b7773eda9
Submitter: Jenkins
Branch: master

commit 77b4bd53dae1882ae3094597e674218b7773eda9
Author: Carlos Camacho <email address hidden>
Date: Thu Apr 27 11:00:32 2017 +0200

    Fix for the resource ControllerPostPuppetMaintenanceModeDeployment

    Closes-Bug:1686619

    Change-Id: I7c32ca39a456de9833d30c31d41fcb727d2b0a34

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/462037

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/462037
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=687b0dadca3e94ed9cfcbc2651522ceccc188e1d
Submitter: Jenkins
Branch: stable/ocata

commit 687b0dadca3e94ed9cfcbc2651522ceccc188e1d
Author: Carlos Camacho <email address hidden>
Date: Thu Apr 27 11:00:32 2017 +0200

    Fix for the resource ControllerPostPuppetMaintenanceModeDeployment

    Depends-On: If88f403c85b79bd896a24c7816486709bd67706f
    Closes-Bug:1686619
    Change-Id: I7c32ca39a456de9833d30c31d41fcb727d2b0a34
    (cherry picked from commit 77b4bd53dae1882ae3094597e674218b7773eda9)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.2.0 release.