Revert rabbit's default ha-mode to 'all'

[Michele Baldessari]

In change Ib62001c03e1e08f58cf0c6e0ba07a8879a584084 we switched the rabbitmq queues HA mode from ha-all to ha-exactly. While this gives us a nice performance boost with rabbitmq, it makes rabbit less resilient to network glitches as we painfully found out via https://bugzilla.redhat.com/show_bug.cgi?id=1441635.

We should switch the default back to 'ha-mode: all' but still allow the operator to deploy with ha-mode: exactly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/459994

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/459998

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/460202

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/460204

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/459994
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=c504d6a8591bcf12e31d97a62222d7611941b136
Submitter: Jenkins
Branch: master

commit c504d6a8591bcf12e31d97a62222d7611941b136
Author: Michele Baldessari <email address hidden>
Date: Wed Apr 26 10:12:50 2017 +0200

    Add a flag to rabbitmq so that we can deploy with ha-mode: all again

    In change Ib62001c03e1e08f58cf0c6e0ba07a8879a584084 we switched the
    rabbitmq queues HA mode from ha-all to ha-exactly. While this gives us a
    nice performance boost with rabbitmq, it makes rabbit less resilient to
    network glitches as we painfully found out via
    https://bugzilla.redhat.com/show_bug.cgi?id=1441635.

    Will propose another THT change to actually change the default to
    -1 so we get this ha-mode:all by default.

    Change-Id: I9a90e71094b8d8d58b5be0a45a2979701b0ac21c
    Partial-Bug: #1686337
    Co-Authored-By: Damien Ciabrini <email address hidden>
    Co-Authored-By: John Eckersberg <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/460204
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=0eeee9a587d845bbf0f5c0d36b719fc890d28bac
Submitter: Jenkins
Branch: stable/ocata

commit 0eeee9a587d845bbf0f5c0d36b719fc890d28bac
Author: Michele Baldessari <email address hidden>
Date: Wed Apr 26 10:12:50 2017 +0200

    Add a flag to rabbitmq so that we can deploy with ha-mode: all again

    In change Ib62001c03e1e08f58cf0c6e0ba07a8879a584084 we switched the
    rabbitmq queues HA mode from ha-all to ha-exactly. While this gives us a
    nice performance boost with rabbitmq, it makes rabbit less resilient to
    network glitches as we painfully found out via
    https://bugzilla.redhat.com/show_bug.cgi?id=1441635.

    Will propose another THT change to actually change the default to
    -1 so we get this ha-mode:all by default.

    Change-Id: I9a90e71094b8d8d58b5be0a45a2979701b0ac21c
    Partial-Bug: #1686337
    Co-Authored-By: Damien Ciabrini <email address hidden>
    Co-Authored-By: John Eckersberg <email address hidden>
    (cherry picked from commit c504d6a8591bcf12e31d97a62222d7611941b136)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/459998
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=90fc4b2e27ef6f612a82dfc5e08884629d0fe0bf
Submitter: Jenkins
Branch: master

commit 90fc4b2e27ef6f612a82dfc5e08884629d0fe0bf
Author: Michele Baldessari <email address hidden>
Date: Wed Apr 26 10:29:18 2017 +0200

    Change the default for rabbitmq back to ha-mode: all

    In change Ib62001c03e1e08f58cf0c6e0ba07a8879a584084 we switched the
    rabbitmq queues HA mode from ha-all to ha-exactly. While this gives us a
    nice performance boost with rabbitmq, it makes rabbit less resilient to
    network glitches as we painfully found out via
    https://bugzilla.redhat.com/show_bug.cgi?id=1441635.

    This is the THT part of the change that changes the default to
    ha-mode: all.

    Closes-Bug: #1686337
    Co-Authored-By: Damien Ciabrini <email address hidden>
    Co-Authored-By: John Eckersberg <email address hidden>

    Change-Id: I7afcf2b3c8deb13fc2134e4cae9c06a44e775384
    Depends-On: I9a90e71094b8d8d58b5be0a45a2979701b0ac21c

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/460202
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ff4db0db59184d23795ffde209974c9f57a63e2a
Submitter: Jenkins
Branch: stable/ocata

commit ff4db0db59184d23795ffde209974c9f57a63e2a
Author: Michele Baldessari <email address hidden>
Date: Wed Apr 26 10:29:18 2017 +0200

    Change the default for rabbitmq back to ha-mode: all

    In change Ib62001c03e1e08f58cf0c6e0ba07a8879a584084 we switched the
    rabbitmq queues HA mode from ha-all to ha-exactly. While this gives us a
    nice performance boost with rabbitmq, it makes rabbit less resilient to
    network glitches as we painfully found out via
    https://bugzilla.redhat.com/show_bug.cgi?id=1441635.

    This is the THT part of the change that changes the default to
    ha-mode: all.

    NB: not clean cherry-pick due to the added metadata_settings line in
    master

    Closes-Bug: #1686337
    Co-Authored-By: Damien Ciabrini <email address hidden>
    Co-Authored-By: John Eckersberg <email address hidden>

    Change-Id: I7afcf2b3c8deb13fc2134e4cae9c06a44e775384
    Depends-On: I9a90e71094b8d8d58b5be0a45a2979701b0ac21c
    (cherry picked from commit 90fc4b2e27ef6f612a82dfc5e08884629d0fe0bf)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.2.0 release.