Since moving some validations to mistral deploy warnings seem to be broken

[Michele Baldessari]

+ openstack overcloud deploy --templates /home/stack/tripleo-heat-templates --libvirt-type qemu --control-flavor oooq_control --compute-flavor oooq_compute --ceph-storage-flavor oooq_ceph --block-storage-flavor oooq_blockstorage --swift-storage-flavor oooq_objectstorage --timeout 90 -e /home/stack/cloud-names.yaml -e /home/stack/tripleo-heat-templates/environments/network-isolation.yaml -e /home/stack/tripleo-heat-templates/environments/net-single-nic-with-vlans.yaml -e /home/stack/network-environment.yaml -e /home/stack/tripleo-heat-templates/environments/puppet-pacemaker.yaml -e /home/stack/tripleo-heat-templates/environments/low-memory-usage.yaml --validation-warnings-fatal --control-scale 3 --ntp-server pool.ntp.org -e ha-docker.yaml
Started Mistral Workflow tripleo.validations.v1.check_pre_deployment_validations. Execution ID: 390ad74c-bcf3-476b-bcaa-1c27cee50377
Waiting for messages on queue 'c9b8c2f9-4ea8-44b7-a707-67c61641ccc4' with no timeout.
{u'errors': [u'Error: only 0 of 3 requested ironic nodes are tagged to profile None (for flavor oooq_control).\nRecommendation: tag more nodes using openstack baremetal node set --property "capabilities=profile:None,boot_option:local" <NODE ID>'], u'warnings': []}

ERRORS
[u'Error: only 0 of 3 requested ironic nodes are tagged to profile None (for flavor oooq_control).\nRecommendation: tag more nodes using openstack baremetal node set --property "capabilities=profile:None,boot_option:local" <NODE ID>', u'Error: only 0 of 3 requested ironic nodes are tagged to profile None (for flavor oooq_control).\nRecommendation: tag more nodes using openstack baremetal node set --property "capabilities=profile:None,boot_option:local" <NODE ID>']
Configuration has 2 errors, fix them before proceeding. Ignoring these errors is likely to lead to a failed deploy.

Note that as soon as I add --validation-errors-nonfatal the deploy is actually successful.

I think this came via If6460877188af4d006df5f75ab5a921b411088e2 and bug #1638697:
commit 65a1e19a6da30c12eccf6db53e61d00a6e18327e
Author: Brad P. Crochet <email address hidden>
Date: Mon Feb 6 07:57:47 2017 -0500

    Implement verify profiles as a custom action

Note that the error: "only 0 of 3 requested ironic nodes are tagged to profile None (for flavor oooq_control)" makes no sense because the flavor oooq_control has profile:control and the ironic nodes are correctly tagged with profile:control in the capabilities.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/459704

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/459704
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=6d487c39fd17f41ad6540fba4ce171c022b2cc09
Submitter: Jenkins
Branch: master

commit 6d487c39fd17f41ad6540fba4ce171c022b2cc09
Author: Brad P. Crochet <email address hidden>
Date: Tue Apr 25 10:03:03 2017 -0400

    Move the gathering of flavors into the CollectFlavors action

    The imported actions from Mistral (namely, the nova.flavors_list)
    will return dictionaries. The nova api returns a Flavor, which has
    additional methods (get_keys) that have further properties that are
    not returned in the main api call. This works around that.

    Change-Id: I3ac99bc5abbae62bfc4352db708e25f5fa551095
    Closes-Bug: #1685177

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 7.1.0 release.