"Save And Close" button is unlocalized

Bug #1685089 reported by Yuko Katabami
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Unassigned

Bug Description

"Deployment Configuration" dialog > "Parameters" tab

There is an unlocalized button labeled "Save And Close" at the bottom of this tab.
The translation is available in Zanata -- the same button on "Overall Settings" tab in this dialog is localized. For some reason, this button does not show the translation in the UI.

Tags: i18n ui
Revision history for this message
Yuko Katabami (ykatabam) wrote :
tags: added: ui
tags: added: i18n
Revision history for this message
Julie Pichon (jpichon) wrote :

I think this should be fixed with this translation patch, which merged only 2 days ago due to some CI issues -> https://review.openstack.org/#/c/456118/ . Keeping bug open until I or someone else can verify.

Changed in tripleo:
status: New → Triaged
importance: Undecided → Medium
milestone: none → pike-2
Yuko Katabami (ykatabam)
description: updated
Changed in tripleo:
milestone: pike-2 → pike-3
Changed in tripleo:
milestone: pike-3 → pike-rc1
Changed in tripleo:
milestone: pike-rc1 → queens-1
Changed in tripleo:
milestone: queens-1 → queens-2
Changed in tripleo:
milestone: queens-2 → queens-3
Revision history for this message
sandeep_s (sandeep-shedmake) wrote :

From Comment 2,

Verified the fix (screenshot attached).

Tested the fix with downstream (based on Pike).

Also,
$ grep -A2 'Save And Close' stable-pike/i18n/ja.po
msgid "Save And Close"
msgstr "保存して閉じる"

$ echo $?
0

Changed in tripleo:
milestone: queens-3 → queens-rc1
Changed in tripleo:
milestone: queens-rc1 → rocky-1
Revision history for this message
sandeep_s (sandeep-shedmake) wrote :

As per comment #3, reported issue is fixed and can be closed with appropriate resolution.

Revision history for this message
Julie Pichon (jpichon) wrote :

I had missed the update, thanks for following up and also including a screenshot!

Changed in tripleo:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.