container puppet -- could not find Service[libvirt] for relationship

[Jiří Stránský]

This has been seen in container upgrade CI:

Apr 19 10:50:53 centos-7-2-node-infracloud-vanilla-8482220-534323 os-collect-config: #033[1;31mError: Could not find resource 'Service[libvirt]' for relationship from 'File_line[/etc/libvirt/libvirtd.conf listen_tls]' on node centos-7-2-node-infracloud-vanilla-8482220-534323#033[0m

http://logs.openstack.org/84/450784/15/experimental/gate-tripleo-ci-centos-7-containers-multinode-upgrades-nv/823dfd7/logs/subnode-2/var/log/messages.txt.gz#_Apr_19_10_50_53

[Bogdan Dobrelya (bogdando)]

The solution is to Noop referenced puppet services for containers as well

[Bogdan Dobrelya (bogdando)]

I'm recalled with that mail thread http://lists.openstack.org/pipermail/openstack-dev/2015-August/073268.html, the issue looks very simlar to that I'd had with neutron classes isolated into separate puppet catalogs

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/458414

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/458414
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8c171167f6e6d00b2426e5242d4a3227bb42d0e6
Submitter: Jenkins
Branch: master

commit 8c171167f6e6d00b2426e5242d4a3227bb42d0e6
Author: Jiri Stransky <email address hidden>
Date: Thu Apr 20 11:25:23 2017 +0200

    Don't attempt to configure live migration

    When configuring nova containers via puppet, the puppet class chain
    includes a class for live migration, which configures live migration
    aspects in nova and libvirt.

    Some of the libvirt config parts try to notify Service[libvirt], but
    that service definition is only included in nova-libvirt service, it's
    not included in the control plan nova services. However, our hieradata
    is currently global on the node, it's not per-service, which means even
    though only nova-compute and nova-libvirt service set

      tripleo::profile::base::nova::manage_migration: true

    this hiera setting is applied to all containers running puppet, most
    notably the ones which configure nova control plane services. As a
    result, configuration of nova control plane services failed, and in turn
    the whole deployment failed.

    This commit disables the libvirt part of live migration config until we
    implement some better solution (e.g. hieradata separation between
    different puppet containers, or move the libvirt config parts only to
    nova-compute manifests in puppet-tripleo).

    Change-Id: I0328406607d451e6bdce4d92c441c03648925fa7
    Closes-Bug: #1684107

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b2 development milestone.