SR-IOV deployment failed with new hiera data hook changes

Bug #1675036 reported by Saravanan KR on 2017-03-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Critical
Saravanan KR

Bug Description

With the change [1], the format of the nova::compute::pci_passthrough value is changed from string to JSON. But as per the puppet-nova implementation, the parameter is expected as JSON encoded string. Modify this parameter a string.

[1] https://github.com/openstack/tripleo-heat-templates/commit/787685101179f13f6074901070cf307bd9bb0731#diff-99a22d37b829681d157f41d35c38e4c5L100

Saravanan KR (skramaja) on 2017-03-22
Changed in tripleo:
assignee: nobody → Saravanan KR (skramaja)

Fix proposed to branch: master
Review: https://review.openstack.org/448600

Changed in tripleo:
status: New → In Progress
Brent Eagles (beagles) wrote :

I initially set importance to medium but it is actually critical for SR-IOV support so I'm upping it to critical

Changed in tripleo:
importance: Undecided → Medium
milestone: none → pike-1
tags: added: ocata-backport-potential
Changed in tripleo:
importance: Medium → Critical

Reviewed: https://review.openstack.org/448600
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=57c06ddefd4d7ff87de02dab9d1c5e92eb8e6eef
Submitter: Jenkins
Branch: master

commit 57c06ddefd4d7ff87de02dab9d1c5e92eb8e6eef
Author: Saravanan KR <email address hidden>
Date: Wed Mar 22 19:40:29 2017 +0530

    Modify pci_passthrough hiera value as string

    Hiera value of nova::compute::pci_passthrough should be a string.
    It has been modified to JSON with the heira hook changes. Modifying
    it again back to string.
    Closes-Bug: #1675036

    Change-Id: I441907ff313ecc5b7b4da562c6be195687fc6c76

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b1 development milestone.

Reviewed: https://review.openstack.org/451168
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8a4c6cbdf5e70b92f2e6b123f36545c957425d08
Submitter: Jenkins
Branch: stable/ocata

commit 8a4c6cbdf5e70b92f2e6b123f36545c957425d08
Author: Saravanan KR <email address hidden>
Date: Wed Mar 22 19:40:29 2017 +0530

    Modify pci_passthrough hiera value as string

    Hiera value of nova::compute::pci_passthrough should be a string.
    It has been modified to JSON with the heira hook changes. Modifying
    it again back to string.
    Closes-Bug: #1675036

    Change-Id: I441907ff313ecc5b7b4da562c6be195687fc6c76
    (cherry picked from commit 57c06ddefd4d7ff87de02dab9d1c5e92eb8e6eef)

tags: added: in-stable-ocata

This issue was fixed in the openstack/tripleo-heat-templates 6.1.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers