RFE: consolidate ref's to dstat log file to a shared variable

[Matt Young]

As part of a patch to remove old log files vs. appending forever (https://review.openstack.org/#/c/437148) In the comment / feedback thread it was suggested that we refactor all of the hard coded instances of "/var/log/extra/dstat.csv" to a variable. Here's the current list...

#---
[tripleo-quickstart] $ grep -rn dstat-csv
roles/environment/teardown/tasks/main.yml:55: file: dest=/var/log/extra/dstat-csv.log state=absent
roles/environment/setup/tasks/main.yml:95: we probably need to in general audit to look for other issues of this type. \
#---
tripleo-quickstart-extras] $ grep -rn dstat-csv
roles/validate-tempest/tasks/stackviz.yml:27: stat: path=/var/log/extra/dstat-csv.log
roles/validate-tempest/tasks/stackviz.yml:32: tempest_dstat_opt: '--dstat /var/log/extra/dstat-csv.log'
roles/collect-logs/tasks/collect.yml:100: stat: path=/var/log/extra/dstat-csv.log
roles/collect-logs/tasks/collect.yml:111: shell: "/tmp/dstat_graph/generate_page.sh /var/log/extra/dstat-csv.log > /var/log/extra/dstat.html"
roles/undercloud-deploy/tasks/install-undercloud.yml:8: dstat -tcmndrylpg --nocolor --output /var/log/extra/dstat-csv.log 1 7200 \
---

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/557455
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=b5e349bc478a5b3bf4bd896224a888843a2fc21b
Submitter: Zuul
Branch: master

commit b5e349bc478a5b3bf4bd896224a888843a2fc21b
Author: Rafael Folco <email address hidden>
Date: Wed Mar 28 14:46:43 2018 -0300

    Collect dstat on overcloud nodes

    Start dstat on overcloud before tempest runs.

    Closes-Bug: #1674382

    Change-Id: Ifd4bea27b2c5f31b30580c098024ba55c8abda51

[Matt Young (halcyondude)]

The commit landed doesn't include dstat being launched during libvirt provisioning, but it does cover the other cases (UC install, OC nodes)

flipping back to triaged...we need a commit to TQ, although this introduced a TQ --> TQE dependency. Not sure (atm) what the right thing to do here is...thoughts?

[Juan Antonio Osorio Robles (juan-osorio-robles)]

Is this still an issue?

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-quickstart-extras 2.1.1 release.