Duplicated message to instruct/warn user to use lowercase letters in Custom Profile field

Bug #1673526 reported by Yuko Katabami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Liz Blanchard

Bug Description

Although Custom Profile field has the string "Must be lowercase with dashes as a separator" shown below, when you attempt to enter upper case or non ascii characters, it shows additional very similar message "Must be lowercase with dashes as a separator".

Both are shown in red to warn users, however it seems redundant to show two very similar messages, and perhaps better to be consolidated into a single message or two different messages.
(e.g. second message to say "You entered characters that are not allowed for this value".

Also, the allowed characters should be described more specifically.
Instead of "lowercase", it should be something like "lowercase alphanumeric characters and hyphen".

Revision history for this message
Julie Pichon (jpichon) wrote :

Thank you for including a suggestion for a more precise message, I think it would work well.

https://github.com/openstack/tripleo-ui/blob/master/src/js/components/nodes/tag_nodes/TagNodesForm.js

tags: added: i18n low-hanging-fruit ui
Changed in tripleo:
status: New → Triaged
importance: Undecided → Medium
milestone: none → pike-1
Changed in tripleo:
milestone: pike-1 → pike-2
Changed in tripleo:
milestone: pike-2 → pike-3
Changed in tripleo:
milestone: pike-3 → pike-rc1
Changed in tripleo:
milestone: pike-rc1 → queens-1
Changed in tripleo:
milestone: queens-1 → queens-2
Changed in tripleo:
milestone: queens-2 → queens-3
Changed in tripleo:
milestone: queens-3 → queens-rc1
Changed in tripleo:
assignee: nobody → Liz Blanchard (lblanchard)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/539299

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/539299
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=be164f301a7b5a4d255e736a17a641d08d01b16c
Submitter: Zuul
Branch: master

commit be164f301a7b5a4d255e736a17a641d08d01b16c
Author: Liz Blanchard <email address hidden>
Date: Tue Jan 30 13:58:10 2018 -0500

    Update Custom Profile field help/error messages

    This contribution updates the inline help message as well as the
    error message for the Custom Profile field to be more user friendly.
    This field can be seen when the user chooses to tag a node with a
    "Custom Profile".

    Change-Id: I2a88a4fc5f58c7d61e981f1db2130e07e8054310
    Closes-Bug: #1673526

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 8.3.0

This issue was fixed in the openstack/tripleo-ui 8.3.0 release.

Revision history for this message
Yuko Katabami (ykatabam) wrote :

Thank you very much.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.