machine-id on overcloud images are identical

Bug #1672461 reported by Alex Schultz on 2017-03-13
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tripleo
High
Alex Schultz

Bug Description

the /etc/machine-id is identical on all overcloud nodes as this file is improperly being shipped as part of the overcloud image.

Changed in tripleo:
importance: Medium → High
tags: added: ocata-backport-potential

Related fix proposed to branch: master
Review: https://review.openstack.org/445173

Changed in tripleo:
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/445173
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=c7c1da513eb003c1a60822b236bde08ace7ea083
Submitter: Jenkins
Branch: master

commit c7c1da513eb003c1a60822b236bde08ace7ea083
Author: Alex Schultz <email address hidden>
Date: Mon Mar 13 14:35:13 2017 -0600

    Add remove-machine-id element

    Leaving /etc/machine-id on the image means that all nodes booted from
    this image will have the same machine-id, which is wrong. A new
    machine-id will be generated during the first boot. This element can be
    used to purge the machine-id from the image.

    Change-Id: Idd848cd307c179afa557618f44db34b2fb57d937
    Related-Bug: #1672461
    Co-Authored-By: Dmitry Tantsur <email address hidden>

Reviewed: https://review.openstack.org/445174
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=44ff6913a2dcaf9c49088b6dae73cc37a3ee9b21
Submitter: Jenkins
Branch: master

commit 44ff6913a2dcaf9c49088b6dae73cc37a3ee9b21
Author: Alex Schultz <email address hidden>
Date: Mon Mar 13 14:39:06 2017 -0600

    Remove machine-id from image

    We should not be providing a machine-id in the overcloud images, so use
    the remove-machine-id element to make sure it is cleaned from the
    overcloud image during the build process.

    Change-Id: I1d4f86ca9f173195ac4477be43b62a0ce388cc79
    Depends-On: Idd848cd307c179afa557618f44db34b2fb57d937
    Closes-Bug: #1672461

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/tripleo-common 7.0.0.0b1 development milestone.

Alex Schultz (alex-schultz) wrote :

Looks like this is still a problem

Changed in tripleo:
status: Fix Released → Triaged
milestone: pike-1 → none
milestone: none → pike-rc1
David Hill (david-hill-ubisoft) wrote :

I was working on this [1] prior finding this upstream bug ...

https://review.openstack.org/#/c/489013/

David Hill (david-hill-ubisoft) wrote :

We'll hit this issue [1] if we use rm .

[1] https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1508766

Alex Schultz (alex-schultz) wrote :

I think I might have tracked it down, the fix for tripleo might just need to be executable (it's currently not)

Also, /etc/machine-id should not be deleted unless it's being touched afterward.

Changed in tripleo:
milestone: pike-rc1 → pike-rc2

Reviewed: https://review.openstack.org/493684
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=c95399a43ac880e23245533a9824b87c333fbeb5
Submitter: Jenkins
Branch: stable/ocata

commit c95399a43ac880e23245533a9824b87c333fbeb5
Author: Alex Schultz <email address hidden>
Date: Mon Mar 13 14:35:13 2017 -0600

    Add remove-machine-id element

    Leaving /etc/machine-id on the image means that all nodes booted from
    this image will have the same machine-id, which is wrong. A new
    machine-id will be generated during the first boot. This element can be
    used to purge the machine-id from the image.

    Change-Id: Idd848cd307c179afa557618f44db34b2fb57d937
    Related-Bug: #1672461
    Co-Authored-By: Dmitry Tantsur <email address hidden>
    (cherry picked from commit c7c1da513eb003c1a60822b236bde08ace7ea083)

tags: added: in-stable-ocata
Changed in tripleo:
milestone: pike-rc2 → queens-1
Alex Schultz (alex-schultz) wrote :

Updating status as this landed in master but the backports are still pending (ci issues)

Changed in tripleo:
milestone: queens-1 → pike-rc2
status: Triaged → Fix Released

Reviewed: https://review.openstack.org/493685
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=a96721ad721e400f474b2032022f930a2d2a6cf4
Submitter: Jenkins
Branch: stable/ocata

commit a96721ad721e400f474b2032022f930a2d2a6cf4
Author: Alex Schultz <email address hidden>
Date: Mon Mar 13 14:39:06 2017 -0600

    Remove machine-id from image

    We should not be providing a machine-id in the overcloud images, so use
    the remove-machine-id element to make sure it is cleaned from the
    overcloud image during the build process.

    Change-Id: I1d4f86ca9f173195ac4477be43b62a0ce388cc79
    Depends-On: Idd848cd307c179afa557618f44db34b2fb57d937
    Closes-Bug: #1672461
    (cherry picked from commit 44ff6913a2dcaf9c49088b6dae73cc37a3ee9b21)

Reviewed: https://review.openstack.org/505305
Committed: https://git.openstack.org/cgit/openstack/tripleo-puppet-elements/commit/?id=ee24f5d97bcd37d09281b7a0d6f1c8cf196d1f3f
Submitter: Jenkins
Branch: stable/newton

commit ee24f5d97bcd37d09281b7a0d6f1c8cf196d1f3f
Author: Alex Schultz <email address hidden>
Date: Mon Mar 13 14:35:13 2017 -0600

    Add remove-machine-id element

    Leaving /etc/machine-id on the image means that all nodes booted from
    this image will have the same machine-id, which is wrong. A new
    machine-id will be generated during the first boot. This element can be
    used to purge the machine-id from the image.

    Change-Id: Idd848cd307c179afa557618f44db34b2fb57d937
    Related-Bug: #1672461
    Co-Authored-By: Dmitry Tantsur <email address hidden>
    (cherry picked from commit c7c1da513eb003c1a60822b236bde08ace7ea083)
    (cherry picked from commit c95399a43ac880e23245533a9824b87c333fbeb5)

tags: added: in-stable-newton

Reviewed: https://review.openstack.org/505310
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=f62e8f966d89e1be3825a9fd6d23a02a52981a0e
Submitter: Jenkins
Branch: stable/newton

commit f62e8f966d89e1be3825a9fd6d23a02a52981a0e
Author: Alex Schultz <email address hidden>
Date: Mon Mar 13 14:39:06 2017 -0600

    Remove machine-id from image

    We should not be providing a machine-id in the overcloud images, so use
    the remove-machine-id element to make sure it is cleaned from the
    overcloud image during the build process.

    Change-Id: I1d4f86ca9f173195ac4477be43b62a0ce388cc79
    Depends-On: Id3f8c510801f8fcc1fc03415b0ebd23a2ff9da4c
    Closes-Bug: #1672461
    (cherry picked from commit 44ff6913a2dcaf9c49088b6dae73cc37a3ee9b21)
    (cherry picked from commit a96721ad721e400f474b2032022f930a2d2a6cf4)

This issue was fixed in the openstack/tripleo-common 6.1.2 release.

This issue was fixed in the openstack/tripleo-common 5.4.4 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers