I18N component breaks nodes actions toolbar

Bug #1671100 reported by Florian Fuchs on 2017-03-08
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tripleo
High
Florian Fuchs

Bug Description

The <FormattedMessage> component used for I18N adds an additional span tag to some of the buttons in the nodes actions toolbar. If this button is clicked, the event target is the span element, not the button element. The button element however has a "name" attribute which is needed to determine what to do after the click. Since the button is no longer the target of the click event, this attribute isn't recognized and nothing happens.

This could be fixed by checking the name attribute of the parent element of the event target.

As a workaround, users can use shift+tab after selecting a node to bring back the focus to the button and trigger the introspection by pressing enter.

This problem might occur in other places as well.

Changed in tripleo:
assignee: nobody → Florian Fuchs (flo-fuchs)
Julie Pichon (jpichon) on 2017-03-08
tags: added: ocata-backport-potential
Changed in tripleo:
milestone: none → pike-1

Fix proposed to branch: master
Review: https://review.openstack.org/443139

Changed in tripleo:
status: Triaged → In Progress
Changed in tripleo:
importance: Critical → High

Reviewed: https://review.openstack.org/443139
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=8d40ed773b08575a6d8345e116049203e204fa43
Submitter: Jenkins
Branch: master

commit 8d40ed773b08575a6d8345e116049203e204fa43
Author: Florian Fuchs <email address hidden>
Date: Wed Mar 8 15:03:38 2017 +0100

    Fix nodes actions toolbar

    An additional span inside the nodes toolbar, added by the i18n
    FormattedMessage component, breaks the toolbar by changing the click
    event target to the span element; because the span element doesn't
    contain the "name" attribute needed to determine the appropriate action.

    This patch adds a small method to lookup the closest name attribute
    (either on the element or the parent elements), so both buttons with and
    without a FormattedMessage of them will work.

    Change-Id: I7c565da8bf2f5040ff99b13f02cb0a7f4c07637f
    Closes-Bug: #1671100

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/444165
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=a2225d5141e681690cd285417a59611511ecc183
Submitter: Jenkins
Branch: stable/ocata

commit a2225d5141e681690cd285417a59611511ecc183
Author: Florian Fuchs <email address hidden>
Date: Wed Mar 8 15:03:38 2017 +0100

    Fix nodes actions toolbar

    An additional span inside the nodes toolbar, added by the i18n
    FormattedMessage component, breaks the toolbar by changing the click
    event target to the span element; because the span element doesn't
    contain the "name" attribute needed to determine the appropriate action.

    This patch adds a small method to lookup the closest name attribute
    (either on the element or the parent elements), so both buttons with and
    without a FormattedMessage of them will work.

    Change-Id: I7c565da8bf2f5040ff99b13f02cb0a7f4c07637f
    Closes-Bug: #1671100
    (cherry picked from commit 8d40ed773b08575a6d8345e116049203e204fa43)

tags: added: in-stable-ocata

This issue was fixed in the openstack/tripleo-ui 7.0.0 release.

This issue was fixed in the openstack/tripleo-ui 3.2.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers