PrePuppet/PreConfig duplication leads to confusion

[Steven Hardy]

I've been asked why we have the *PreConfig interfaces for each role, as they are unused and duplicate (from an operator perspective) the ExtraConfigPre hooks we already documented.

However looking at the history, this is a mistake, as they were intended to be internal interfaces, but we reverted back to the old PrePuppet naming by mistake:

Here, I removed the *PrePuppet interfaces, replacing them with per-role
*PreConfig interfaces (intended to do the same thing but be an
implementation agnostic name):

https://review.openstack.org/#/c/365763/14/overcloud-resource-registry-puppet.yaml

However here, we've re-introduced it:

https://review.openstack.org/#/c/393644/

And here we generate it for all roles:

https://review.openstack.org/#/c/434451

Effectively we've reverted my original renaming, which leaves the
*PreConfig interface unused - this isn't intended for users really
(although clearly they could use it right now), so we need to decide how to
proceed (I'd vote to deprecate and remove *PrePuppet and move to the
*PreConfig, since we've never documented *PreConfig as a user-interface).

[Carlos Camacho (ccamacho)]

Fix proposed in: https://review.openstack.org/#/c/452734/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/459229

[OpenStack Infra (hudson-openstack)]

Change abandoned by Carlos Camacho (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/459229
Reason: I'll abandon this, and cherry-pick it once it's merged.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/452734
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=258c6ce52d0c8467f34693722a883d96345802b2
Submitter: Jenkins
Branch: master

commit 258c6ce52d0c8467f34693722a883d96345802b2
Author: Carlos Camacho <email address hidden>
Date: Mon Apr 3 14:24:06 2017 +0200

    Merge pre|post puppet resources into pre|post config.

    The [Pre|Post]Puppet resources were renamed in
    https://review.openstack.org/#/c/365763.
    This was intended for having a pre/post deployment
    steps using an agnostic name instead of
    being attached to a technology.

    The renaming was unintentionally reverted in
    https://review.openstack.org/#/c/393644/ and
    https://review.openstack.org/#/c/434451.

    This submission merge both resources into one,
    and remove the old pre|post hooks.

    Closes-bug: #1669756
    Change-Id: Ic9d97f172efd2db74255363679b60f1d2dc4e064

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/459572

[OpenStack Infra (hudson-openstack)]

Change abandoned by Carlos Camacho (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/459572

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/459229
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ffb7ba51e19caba276ee256f7083833e9bcf3b76
Submitter: Jenkins
Branch: stable/ocata

commit ffb7ba51e19caba276ee256f7083833e9bcf3b76
Author: Jenkins <email address hidden>
Date: Mon Apr 24 18:42:00 2017 +0000

    Merge pre|post puppet resources into pre|post config.

    The [Pre|Post]Puppet resources were renamed in
    https://review.openstack.org/#/c/365763.
    This was intended for having a pre/post deployment
    steps using an agnostic name instead of
    being attached to a technology.

    The renaming was unintentionally reverted in
    https://review.openstack.org/#/c/393644/ and
    https://review.openstack.org/#/c/434451.

    This submission merge both resources into one,
    and remove the old pre|post hooks.

    Change-Id: Ic9d97f172efd2db74255363679b60f1d2dc4e064
    Closes-bug: #1669756
    (cherry picked from commit 258c6ce52d0c8467f34693722a883d96345802b2)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.2.0 release.