Glance and Neutron worker defaults not working

[Brent Eagles]

The places where we've used default values of an empty string to cause the default puppet values to be used no longer work (possibly due to the fixes on how hieradata is written out). This was kind of a hack in the first place and needs to be fixed. To clarify, this bug applies to any situation where you might otherwise use a sentinel value to indicate that the value shouldn't be set and a heat template condition to skip writing out the hieradata if it isn't.

AFAICT, glance and neutron are the only services affected.

[Brent Eagles (beagles)]

Patch https://review.openstack.org/#/c/425423/

[Ben Nemec (bnemec)]

Interesting. Any idea why this isn't failing https://review.openstack.org/#/c/425420 ? It seems like exactly the sort of thing I was hoping to catch with that change.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/425423
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=60e3687075b4968f208ecbc0e24bd4e318c72380
Submitter: Jenkins
Branch: master

commit 60e3687075b4968f208ecbc0e24bd4e318c72380
Author: Brent Eagles <email address hidden>
Date: Wed Jan 25 17:57:12 2017 -0330

    Use conditionals for neutron and glance worker defaults

    Using an empty string to signal that the default value in the puppet module
    is to be used no longer seems to work, resulting in the puppet specified
    defaults being overridden by empty string values. The impact on
    configuration will differ depending on the actual configuration item, the
    puppet code and the service, so it is just safer to omit the hieradata if
    the user has not explicitly set a value.

    Change-Id: Iefbc8f8669680e4f9d01db6b49543bfbe9b7661b
    Closes-Bug: #1669452

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481587
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9d97427a4f933da3697010738fdf9413f4fb4eec
Submitter: Jenkins
Branch: stable/ocata

commit 9d97427a4f933da3697010738fdf9413f4fb4eec
Author: Jenkins <email address hidden>
Date: Fri Apr 21 03:16:30 2017 +0000

    Use conditionals for neutron and glance worker defaults

    Using an empty string to signal that the default value in the puppet module
    is to be used no longer seems to work, resulting in the puppet specified
    defaults being overridden by empty string values. The impact on
    configuration will differ depending on the actual configuration item, the
    puppet code and the service, so it is just safer to omit the hieradata if
    the user has not explicitly set a value.

    Change-Id: Ic8b55941b05c4888c06e0e57b8994f71c2966034
    Closes-Bug: #1669452
    (cherry picked from commit Iefbc8f8669680e4f9d01db6b49543bfbe9b7661b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.2.1 release.