tripleo

Upgrade from Newton to Ocata fails if not using latest tripleo-common before upgrading

Bug #1669068 reported by Christian Schwede
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Christian Schwede
tripleo pike-1 "pike-1"
Ocata
Fix Released
High
Christian Schwede

Bug Description

If an upgrade started without the latest newton/stable version of tripleo-common, this currently will fail because the temporary URLs used by the Swift ring deployment/updates are not created.

While debugging this I noticed that the workflow is not correct; actually the Swift ring temporary URLs need to be created always before starting the deployment. Without this patch, temporary URLs were not created if validations are not run.

This needs to be fixed for Ocata even if the latest stable/newton release has been deployed before the upgrade started, otherwise it might just fail later on (if validation is skipped).

Christian Schwede (cschwede)
Changed in tripleo:
status: New → In Progress
assignee: nobody → Christian Schwede (cschwede)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/439753

Emilien Macchi (emilienm)
Changed in tripleo:
milestone: none → ocata-rc2
importance: Undecided → High
tags: added: ocata-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/439753
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=d51deebc7d29f45ff9efab4e2a5979fff4e48900
Submitter: Jenkins
Branch: master

commit d51deebc7d29f45ff9efab4e2a5979fff4e48900
Author: Christian Schwede <email address hidden>
Date: Wed Mar 1 19:09:04 2017 +0100

    Fix Swift ring deployment and Newton to Ocata upgrades

    If an upgrade started without the latest newton/stable version of
    tripleo-common, this currently will fail because the temporary URLs are
    not created.

    While debugging this I noticed that the workflow is not correct;
    actually the Swift ring temporary URLs need to be created always before
    starting the deployment. Without this patch, temporary URLs were not
    created if validations are not run - which was the case when upgrading
    the overcloud.

    This needs to be fixed for Ocata even if the latest stable/newton
    release has been deployed before the upgrade started, otherwise it might
    just fail later on (if there are any deployments without doing the
    validations).

    Closes-Bug: 1669068
    Change-Id: I765498c668932e3c95caeb53e4b73d00990898f4

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/441077

Christian Schwede (cschwede)
Changed in tripleo:
status: Fix Released → Fix Committed
Revision history for this message
Steven Hardy (shardy) wrote :

The https://review.openstack.org/#/c/441077 backport didn't actually land in ocata RC2

Changed in tripleo:
milestone: ocata-rc2 → pike-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/ocata)

Reviewed: https://review.openstack.org/441077
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=2c9fa693e3c67d875c4536a4d184fad064fe0225
Submitter: Jenkins
Branch: stable/ocata

commit 2c9fa693e3c67d875c4536a4d184fad064fe0225
Author: Christian Schwede <email address hidden>
Date: Wed Mar 1 19:09:04 2017 +0100

    Fix Swift ring deployment and Newton to Ocata upgrades

    If an upgrade started without the latest newton/stable version of
    tripleo-common, this currently will fail because the temporary URLs are
    not created.

    While debugging this I noticed that the workflow is not correct;
    actually the Swift ring temporary URLs need to be created always before
    starting the deployment. Without this patch, temporary URLs were not
    created if validations are not run - which was the case when upgrading
    the overcloud.

    This needs to be fixed for Ocata even if the latest stable/newton
    release has been deployed before the upgrade started, otherwise it might
    just fail later on (if there are any deployments without doing the
    validations).

    Closes-Bug: 1669068
    Change-Id: I765498c668932e3c95caeb53e4b73d00990898f4
    (cherry picked from commit d51deebc7d29f45ff9efab4e2a5979fff4e48900)

Emilien Macchi (emilienm)
Changed in tripleo:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 7.0.0.0b1

This issue was fixed in the openstack/tripleo-common 7.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 6.1.0

This issue was fixed in the openstack/tripleo-common 6.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/468389

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (stable/newton)

Change abandoned by Lukas Bezdicka (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/468389
Reason: not needed in newton

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.