reduce the number of places to update when new language is added

Bug #1668978 reported by Jiri Tomasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Honza Pokorny

Bug Description

Currently there are 3 places to update when a new language is added to TripleO UI (https://review.openstack.org/#/c/431527/3/docs/translation.rst)

To reduce this, we could update languages in app config to match the format I18nDropdown uses:
"languages": [{"en": "English", {"ja": Japanese}, ...],

and make I18nDropdown populate the list from app config.

We have to maintain the sample app config anyway, so this does not pose any problem for end user.

Tags: i18n ui
Jiri Tomasek (jtomasek)
tags: added: i18n
Changed in tripleo:
milestone: none → pike-1
Honza Pokorny (hpokorny)
Changed in tripleo:
assignee: nobody → Honza Pokorny (hpokorny)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/440788

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/442683

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/440788
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=e8eb44c5176869ac243d9488f61db1e48671bc5a
Submitter: Jenkins
Branch: master

commit e8eb44c5176869ac243d9488f61db1e48671bc5a
Author: Honza Pokorny <email address hidden>
Date: Thu Mar 2 15:59:13 2017 -0400

    Simplify addition of new languages

    Instead of having to update in three places, make it only two.

    Change-Id: I2d28d9019e8bcf9f6b8ef5698958932d44321679
    Partial-Bug: #1668978

Jiri Tomasek (jtomasek)
Changed in tripleo:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/442683
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=60db285fd59eb36bca9d3a209c945e4f23412b3b
Submitter: Jenkins
Branch: master

commit 60db285fd59eb36bca9d3a209c945e4f23412b3b
Author: Honza Pokorny <email address hidden>
Date: Tue Mar 7 14:57:09 2017 -0400

    Refactor enabled languages from an array to a hash

    Change-Id: I5173361818508849e5012a943a984af69d9d08cd
    Depends-On: I2d28d9019e8bcf9f6b8ef5698958932d44321679
    Closes-Bug: #1668978

Changed in tripleo:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 7.0.0

This issue was fixed in the openstack/puppet-tripleo 7.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.