Upgrading compute nodes fails with: Error: Evaluation Error: Error while evaluating a Function Call, Could not find data item step in any Hiera data file and no default supplied at /etc/puppet/modules/tripleo/manifests/profile/base/ceph/client.pp:27:11 on node overcloud-novacompute-0.localdomain

[Marius Cornea]

Upgrading compute nodes fails with: Error: Evaluation Error: Error while evaluating a Function Call, Could not find data item step in any Hiera data file and no default supplied at /etc/puppet/modules/tripleo/manifests/profile/base/ceph/client.pp:27:11 on node overcloud-novacompute-0.localdomain

[stack@undercloud-0 ~]$ upgrade-non-controller.sh --upgrade overcloud-novacompute-0
[..]
exception: connect failed
Notice: hiera(): Cannot load backend module_data: cannot load such file -- hiera/backend/module_data_backend
Warning: Undefined variable 'deploy_config_name';
   (file & line not available)
Notice: hiera(): Cannot load backend module_data: cannot load such file -- hiera/backend/module_data_backend
Error: Evaluation Error: Error while evaluating a Function Call, Could not find data item step in any Hiera data file and no default supplied at /etc/puppet/modules/tripleo/manifests/profile/base/ceph/client.pp:27:11 on node overcloud-novacompute-0.localdomain

[Marios Andreou (marios-b)]

thanks Marius... it looks like we'll have to rework this https://github.com/openstack/tripleo-heat-templates/blob/093949dc5d102d13d857e18427ce671861dc6352/extraconfig/tasks/tripleo_upgrade_node.sh#L48

In the normal case the puppet config is applied as a number of steps https://github.com/openstack/tripleo-heat-templates/blob/093949dc5d102d13d857e18427ce671861dc6352/puppet/puppet-steps.j2#L36 and the step param is passed by the tripleo-heat-templates to be used puppet-tripleo side... the error you have above is from https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/ceph/client.pp#L27

So we need to think about how we apply the puppet config manually for these nodes... lets try and make some progress on this today it is a main blocker right now

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/433641

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/435315

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/433641
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=237cd2004a2c0869d60d0e11e9dccd59e809ff90
Submitter: Jenkins
Branch: master

commit 237cd2004a2c0869d60d0e11e9dccd59e809ff90
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Feb 14 14:20:23 2017 +0100

    Apply puppet in non-controller script in step.

    We want to apply a puppet manifest for the non-controller role, but we
    need to apply it in stages. By loading the proper hieradata we get the
    needed step configuration.

    Change-Id: I07bfeee7b7d9a9b8c2c20e5d5c9ed735d0bfc842
    Closes-Bug: #1664304

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/435315
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3440d9d8caa26f0360be9d9d6110ff46e6e8ddb6
Submitter: Jenkins
Branch: stable/ocata

commit 3440d9d8caa26f0360be9d9d6110ff46e6e8ddb6
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Feb 14 14:20:23 2017 +0100

    Apply puppet in non-controller script in step.

    We want to apply a puppet manifest for the non-controller role, but we
    need to apply it in stages. By loading the proper hieradata we get the
    needed step configuration.

    Change-Id: I07bfeee7b7d9a9b8c2c20e5d5c9ed735d0bfc842
    Closes-Bug: #1664304
    (cherry picked from commit 237cd2004a2c0869d60d0e11e9dccd59e809ff90)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.0.0b1 development milestone.