Raise DriverLoadError if using flat network with cleaning enabled and cleaning_network is not set

[Ruby Loo]

The network interface was added [1] in the Newton (6.1.0) release. So that standalone deployments weren't broken by this new interface, the "flat" network interface did not require the configuration option "[neutron]/cleaning_network" to be set.

According to the release notes, for Ocata, we want to make it required that the option be set.

[1] https://review.openstack.org/#/c/285852/

[Ruby Loo (rloo)]

Here's the TODO: https://github.com/openstack/ironic/blob/375adedce33b5047da0348a2eb9436d96a3a15f8/ironic/drivers/modules/network/flat.py#L39

[Ruby Loo (rloo)]

I don't understand why a flat network requires a cleaning network UUID if cleaning is not enabled.

[Dmitry Tantsur (divius)]

Ugh, I hate it :( In case of TripleO, it requires either providing a fake name, or substantially designing TripleO. Anyway, this is what the team decided.

Adding TripleO to provide urgent actions (probably a fake network name indeed)..

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/428052

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/428066

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/428052
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e32164c300806b61720b99497df79ef2ac0db44e
Submitter: Jenkins
Branch: master

commit e32164c300806b61720b99497df79ef2ac0db44e
Author: Dmitry Tantsur <email address hidden>
Date: Thu Feb 2 10:38:46 2017 +0100

    Provide a default value for Ironic cleaning_network configuration

    Ironic will soon refuse to start when at least some value is not provided.
    Unfortunately, we do not create any overcloud[*] networks during deployment.
    Fortunately, Ironic does not validate this value until actual cleaning. So,
    this change sets it to "provisioning", which is what people often use.

    An update will follow to the documentation to recommend this name:
    http://tripleo.org/advanced_deployment/baremetal_overcloud.html#configuring-cleaning

    A new parameter is created for this value, with a reminded to change it to
    an actual UUID later on. While a pre-defined name will work in a simplest case,
    in a real multi-tenant deployment a network name conflict is possible.
    Using a UUID is safer in this regard.

    [*] networks created in overcloud neutron

    Change-Id: I1b7dc2ff70d3b76f19a183a60e88cf72f6d2a318
    Closes-Bug: #1661082

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/428066
Committed: https://git.openstack.org/cgit/openstack/tripleo-docs/commit/?id=c3cb90a50387087b86590cace23e6ff1c184e8a3
Submitter: Jenkins
Branch: master

commit c3cb90a50387087b86590cace23e6ff1c184e8a3
Author: Dmitry Tantsur <email address hidden>
Date: Thu Feb 2 10:54:01 2017 +0100

    Update bare metal cleaning documentation with latest changes

    * Change recommended network name to "provisioning" (the default in THT for
      the cleaning network) to further emphasize that in real life it should be
      a dedicated network.
    * Document new IronicCleaningNetwork parameter and its default value
    * Update documentation on difference between Newton and Ocata
    * Drop provisioning network information, as we don't support this feature yet.
    * Drop a note on manually setting cleaning network configuration option.
      This is not what we should recommend people do.

    Change-Id: I7711a859265ff03fbfeb95577086dc4744b08fb7
    Depends-On: I1b7dc2ff70d3b76f19a183a60e88cf72f6d2a318
    Related-Bug: #1661082

[Ruby Loo (rloo)]

We discussed this in ironic's weekly meeting today [1]. The consensus was to NOT fail the conductor at startup if 'flat' network and cleaning_network config not set. We will continue issuing a warning message instead.

Note that there is an RFE to allow the cleaning network to be set at the node level [2], which is another good reason not to fail the conductor at start up :)

[1] starting at 17:19:08, http://eavesdrop.openstack.org/meetings/ironic/2017/ironic.2017-02-06-17.00.log.html
[2] https://bugs.launchpad.net/ironic/+bug/1614876

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/429944

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/429944
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=e3bd99f93ad31d0e019612ed6557646d8f9975ac
Submitter: Jenkins
Branch: master

commit e3bd99f93ad31d0e019612ed6557646d8f9975ac
Author: Ruby Loo <email address hidden>
Date: Tue Feb 7 00:20:05 2017 +0000

    log if 'flat' interface and no cleaning network

    Commit cde11611d93946a1c79e406dc429aa5e742da729 added a TODO (in
    Ocata) to raise DriverLoadError if using 'flat' network interface
    and cleaning_network config option is not set.

    After discussions, we decided to keep the logging behaviour,
    because one could use a flat network and not do any cleaning.
    The logging message is updated to reflect this.

    Change-Id: Ida3f3a349655bffc3ed0a307a3c18fbd69b42271
    Fixes-Bug: 1661082

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0rc1 release candidate.