NetApp deploy fails unless ManilaNetAppTraceFlags value is supplied

[Tom Barron]

<email address hidden> reports in https://bugzilla.redhat.com/show_bug.cgi?id=1417980:

Created attachment 1246266 [details]
Manila

Description of problem:
I am trying to set up Manila with NetApp driver in Overcloud using Heat environment files. I set up the environment files and included them with a "-e" parameter in Overcloud creation.

The deployment fails at:
AllNodesDeploySteps | OS::TripleO::PostDeploySteps

If i check the os-collect-config logs I see this:

Jan 31 03:55:02 overcloud-controller-0.localdomain os-collect-config[6843]: Error: Could not find data item manila::backend::netapp::netapp_trace_flags in any Hiera data file and no default supplied at /etc/puppet/modules/tripleo/manifests/profile/pacemaker/manila.pp:117 on node overcloud-controller-0.localdomain
Jan 31 03:55:02 overcloud-controller-0.localdomain os-collect-config[6843]: Error: Could not find data item manila::backend::netapp::netapp_trace_flags in any Hiera data file and no default supplied at /etc/puppet/modules/tripleo/manifests/profile/pacemaker/manila.pp: 117 on node overcloud-controller-0.localdomain
Jan 31 03:55:02 overcloud-controller-0.localdomain os-collect-config[6843]: [2017-01-31 03:55:02,102] (heat-config) [ERROR] Error running /var/lib/heat-config/heat-config-puppet/bce686a8-acdf-4ba9-b903-0b

Version-Release number of selected component (if applicable):
OSP 10

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/427617

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/444314

[OpenStack Infra (hudson-openstack)]

Change abandoned by Tom Barron (<email address hidden>) on branch: master
Review: https://review.openstack.org/427617
Reason: in favor of https://review.openstack.org/#/c/444314/ The problem that this patch attempts to work around does not occur in master.

[Jan Provaznik (jan-provaznik)]

This bug doesn't occur in Ocata and later because of switchign to JSON format in hieradata - https://review.openstack.org/#/c/384757/. Thus the patch above is for Newton branch only.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/444314
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=148eb6103264700fe5095f91ab3582f6bf6a824e
Submitter: Jenkins
Branch: stable/newton

commit 148eb6103264700fe5095f91ab3582f6bf6a824e
Author: Jan Provaznik <email address hidden>
Date: Fri Mar 10 14:38:27 2017 +0100

    Quote empty strings in manila netapp driver

    Empty strings are converted into null values in hieradata
    YAML files and deployment then fails because of missing
    hiera data. Quoting these empty strings assures that deployment
    passes even if a user doesn't override default values.

    This issue is specific to Newton release only, in Ocata JSON
    format is used for hieradata files
    (Ibe7e2044e200e2c947223286fdf4fd5bcf98c2e1).

    Change-Id: I71e74161b302a19e7df2c7ccccf9bc536a68d9c8
    Closes-Bug: #1660930

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.3.0 release.

[Emilien Macchi (emilienm)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

[Ben Nemec (bnemec)]

This bug appears to be fixed on Newton, which was the only release it affected.