Gracefully fails if user is still using old hiera mechanism.

Bug #1659540 reported by Sofer Athlan-Guyot on 2017-01-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Unassigned

Bug Description

Hi,

as described there[1], the new hiera hook is a breaking change in in ocata. As there hasn't been
a deprecation period, we have to make any error very user friendly.

Currently the template deployment are just stuck.

This bug should make sure that we have such mechanism in place. Steve Hardy suggested that 99-refresh-completed could be a good candidate to signal the error.

A strong documentation should go with this change.

[1] http://lists.openstack.org/pipermail/openstack-dev/2017-January/110922.html

Changed in tripleo:
importance: Undecided → Critical
milestone: none → ocata-3
Changed in tripleo:
milestone: ocata-3 → ocata-rc1
status: New → Triaged
Marios Andreou (marios-b) wrote :

fyi related review and discussion at " Fail fast and warn if old hiera data is detected" https://review.openstack.org/#/c/425955/ Iba36f0a7d0225843e1997a8a5a330ad49f5a9e21 tripleo-puppet-elements

Emilien Macchi (emilienm) wrote :

Moving to High, Critical is not accurate, deployments currently run fine.

Changed in tripleo:
importance: Critical → High
Changed in tripleo:
milestone: ocata-rc1 → ocata-rc2
Changed in tripleo:
milestone: ocata-rc2 → pike-1
Marios Andreou (marios-b) wrote :

Note: came here from https://bugzilla.redhat.com/show_bug.cgi?id=1416834 - in the end the review at /#/c/425955/ from comment #1 above was abandoned

Instead we landed https://review.openstack.org/#/c/426241/ I326a2816b6c47b2ba00c33a42ce6e452c5a74dce (openstack/heat-agents)

AFAICS we still need to cherrypick this to ocata, as I can't see it in [3] and my just upgraded OSP11 undercloud with openstack-heat-agents-1.0.0-2.el7ost.noarch doesn't have the fix. I just posted the cherrypick at https://review.openstack.org/#/c/450195/

As discussed on the openstack-dev mailing list at [1] we remove any existing data during the newton to ocata upgrade with [2] so the remaining cherrypick is just for deployments starting at ocata

thanks

[1] http://lists.openstack.org/pipermail/openstack-dev/2017-January/110922.html we
[2] https://github.com/openstack/tripleo-heat-templates/blob/stable/ocata/environments/major-upgrade-composable-steps.yaml#L10-L15
[3] https://github.com/openstack/heat-agents/blob/stable/ocata/heat-config-hiera/install.d/hook-hiera.py

Changed in tripleo:
milestone: pike-1 → pike-2
Changed in tripleo:
milestone: pike-2 → pike-3

This has been "solved" (as in "the best solution we could come up with") in https://review.openstack.org/#/c/450195/, which has been merged in ocata (the review lacks the #, for autoupdating).

Thanks,

Closing it.

Changed in tripleo:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.