Ironic introspection fails because unexpected keyword "insecure"

[Sagi (Sergey) Shnaidman]

Baremetal introspection fails with error:

Introspection completed with errors:
Failed to run action [action_ex_id=68aa6b01-e16b-45a5-aa3b-e31419635c1b, action_cls='<class 'mistral.actions.action_factory.BaremetalIntrospectionAction'>', attributes='{u'client_method_name': u'introspect'}', params='{u'uuid': u'all', u'new_ipmi_username': None, u'new_ipmi_password': None}']
 BaremetalIntrospectionAction.introspect failed: <type 'exceptions.TypeError'>: __init__() got an unexpected keyword argument 'insecure'

http://logs.openstack.org/periodic/periodic-tripleo-ci-centos-7-ovb-nonha/25f1837/console.html#_2017-01-15_07_02_32_683044

The breaking commit: https://github.com/openstack/mistral/commit/1eff558e438564af4c3325c558a38e0462302e8f

The ironic introspection ClientV1 doesn't have a keyword "insecure":
https://github.com/openstack/python-ironic-inspector-client/blob/master/ironic_inspector_client/common/http.py#L97-L108

which is required by new code in mistral:
https://github.com/openstack/mistral/blob/1eff558e438564af4c3325c558a38e0462302e8f/mistral/actions/openstack/actions.py#L445

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/420547

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/420547
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=76f20ee437c595ec8c3abaade99d1a6f3adc0f91
Submitter: Jenkins
Branch: master

commit 76f20ee437c595ec8c3abaade99d1a6f3adc0f91
Author: Dougal Matthews <email address hidden>
Date: Mon Jan 16 07:50:23 2017 +0000

    Remove insecure flag from the Baremetal Introspection client

    The baremetal inspector client does not take the "insecure" argument. It
    was incorrectly added in 600dd4765409068266f2bb2d858e48cf4e0ec245.

    This is currently breaking TripleO.

    Closes-Bug: #1656692
    Change-Id: Ic1f55e9a243302d4d2715654b4d9d4abe5000d2a

[Emilien Macchi (emilienm)]

I'm closing the bug on tripleo side, we've got a promotion. Nice work Dougal!

[Ben Nemec (bnemec)]

I'm reopening until this is proven fixed. The nonha jobs are currently still all failing on this.

[Ben Nemec (bnemec)]

I should have noted that we just had a promotion, so we do believe it's fixed, but I have yet to see a job actually pass. When we do, this can be closed again.

[Ben Nemec (bnemec)]

nonha jobs are passing again

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/mistral 4.0.0.0b3 development milestone.