[RFE] Split Open Vswitch its own service

[Tim Rozet]

Right now there are a bunch of places where assumptions are made that profiles for openvswitch-agent contain openvswitch configuration. The problem with this is that when one goes to implement a new ML2 provider like OpenDaylight, the similar configuration for OVS needs to be done, which results in a duplicate THT template or even composable service. Another example can be seen in:
https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/neutron-ovs-dpdk-agent.yaml

There is configuration there specific to Open Vswitch, which will need to be duplicated into another profile for a usage other than OVS Agent.

It would be nice to split out OVS and OVS agent into their own separate services. That will also pave the way for having other dataplanes be their own service as well, like FD.IO.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/419648
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b30bdb6f8ed7a041d53849cd56718afd08f4bb98
Submitter: Jenkins
Branch: master

commit b30bdb6f8ed7a041d53849cd56718afd08f4bb98
Author: Tim Rozet <email address hidden>
Date: Thu Jan 12 16:07:02 2017 -0500

    Adds service for OVS and enables ODL DPDK deployments

    In order to deploy OpenDaylight with DPDK we need to copy the DPDK
    config for OVS done in the neutron-ovs-dpdk service template, without
    enabling OVS agent for compute nodes. To do this correctly, we should
    inherit and openvswitch service which is a common place to set OVS
    configuration and parameters. Note: vswitch::dpdk config will be called
    in prenetwork setup with ovs_dpdk_config.yaml so there is no need to
    include that in the step config for neutron-ovs-dpdk-agent service or
    opendaylight-ovs-dpdk.

    Changes Include:
     - Creates a common openvswitch service template, which in the future
       will migrate to be its own service.
     - Renames and fixes OVS DPDK configuration heat parameters in the
       openvswitch template.
     - neutron-ovs-dpdk-agent now inherits the common openvswitch template.
     - Adds opendaylight-ovs-dpdk template which also inherits common ovs
       template.
     - Uses OVS DPDK config script to allow configuring OVS DPDK in
       prenetwork config (before os-net-config runs). This has an issue
       where hieradata is not present yet, so we have to redefine the heat
       parameters and pass them via bash. In the future this should be
       corrected.
     - Adds opendaylight-dpdk environment file used to deploy an ODL + DPDK
       deployment.
     - Updates neutron-ovs-dpdk environment file.

    Closes-Bug: 1656097
    Partial-Bug: 1656096

    Depends-On: I3227189691df85f265cf84bd4115d8d4c9f979f3

    Change-Id: Ie80e38c2a9605d85cdf867a31b6888bfcae69e29
    Signed-off-by: Tim Rozet <email address hidden>

[Juan Antonio Osorio Robles (juan-osorio-robles)]

Should we close this? or is this still needed?

[Tim Rozet (trozet)]

It's up to you and the OOO team. I do not plan to work on it.