unable to leverage swap-partition extraconfig

[Alex Schultz]

Following along the same lines of Bug #1625783, it does not appear that you can leverage the swap-partition.yaml or swap.yaml from extraconfig/all_nodes/ in THT

There's a few things, if you follow the direction from the previous bug, it'll just error because it can't find swap.yaml (or swap-parition.yaml). I was able to progress by moving my swap.yaml environment file that contained my resource_registry to the root of my THT directory. (This really needs to get documented better) However the next issue was that I get a validation error from the deployment action:

ERROR: Failed to validate: : resources.AllNodesExtraConfig: : "" is not a map'

Heat engine logs exception: http://paste.openstack.org/show/593211/

Setup:
[centos@undercloud tripleo-heat-templates]$ pwd
/home/centos/tripleo-heat-templates
[centos@undercloud tripleo-heat-templates]$ cat swap.yaml
resource_registry:
  OS::TripleO::AllNodesExtraConfig: extraconfig/all_nodes/swap-partition.yaml

Run:
[centos@undercloud tripleo-heat-templates]$ openstack overcloud deploy --templates /home/centos/tripleo-heat-templates/ -e /home/centos/tripleo-heat-templates/environments/low-memory-usage.yaml -e /home/centos/tripleo-heat-templates/swap.yaml

Actual Results:
Error and sadness

Expected Results:
Deployment with swap

[Carlos Camacho (ccamacho)]

Tagged as Critical as the issue is with the AllNodesExtraConfig resource.

Fix proposed to branch: master
Review: https://review.openstack.org/418273

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/418273
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=92e203aab60eee1d7f99d244a3576f6c6363fa2e
Submitter: Jenkins
Branch: master

commit 92e203aab60eee1d7f99d244a3576f6c6363fa2e
Author: Carlos Camacho <email address hidden>
Date: Tue Jan 10 10:02:14 2017 +0100

    Fix for AllNodesExtraConfig and fix environment files to create swap files/partitions

    This submission:

     - Fix an error in the AllNodesExtraConfig resource.
       (Can't merge servers multiple times).
     - Add environment files to deploy swap file/partition
       without manual edit over the templates.
     - If a swap partition is mounted without having it available
       the deployment will fail, the fix checks that if the
       partition is not created then the deployment continues.
     - Removing empty extra lines in swap templates.
     - Adjust description and remove unnecessary comments in
       swap templates.

    Closes-Bug: 1652184

    Change-Id: I828bbbbd4c178956aac74af49f80fcd4f62fa16b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/421780

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/424079

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/424079
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a8d5ec26292dd69aeceb4eb2283ad8e29af227fd
Submitter: Jenkins
Branch: stable/newton

commit a8d5ec26292dd69aeceb4eb2283ad8e29af227fd
Author: Carlos Camacho <email address hidden>
Date: Tue Jan 10 10:02:14 2017 +0100

    Fix for AllNodesExtraConfig and fix environment files to create swap files/partitions

    This submission:

     - Fix an error in the AllNodesExtraConfig resource.
       (Can't merge servers multiple times).
     - Add environment files to deploy swap file/partition
       without manual edit over the templates.
     - If a swap partition is mounted without having it available
       the deployment will fail, the fix checks that if the
       partition is not created then the deployment continues.
     - Removing empty extra lines in swap templates.
     - Adjust description and remove unnecessary comments in
       swap templates.

    Closes-Bug: 1652184

    Change-Id: I828bbbbd4c178956aac74af49f80fcd4f62fa16b
    (cherry picked from commit 92e203aab60eee1d7f99d244a3576f6c6363fa2e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/421780
Committed: https://git.openstack.org/cgit/openstack/tripleo-docs/commit/?id=c48b0e43c4f0a2bc7ed29db643da2ce17064e376
Submitter: Jenkins
Branch: master

commit c48b0e43c4f0a2bc7ed29db643da2ce17064e376
Author: Carlos Camacho <email address hidden>
Date: Wed Jan 18 11:07:19 2017 +0100

    Add swap usage in the docs.

    Relevant information about how to use
    swap files or partitions in an Overcloud
    deployment.

    Change-Id: I116b699319ac2228ed64682b10ffaab768224769
    Closes-Bug: 1652184

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.3.0 release.