yum update runs on deployment

[Steven Hardy]

For some reason I'm seeing yum update run on deployment, because

https://github.com/openstack/puppet-tripleo/blob/master/manifests/packages.pp#L49

 if $enable_upgrade {
    Package <| |> { ensure => 'latest' }
    # Running the package upgrade before managing Services in the main stage.
    # So we're sure that services will be able to restart with the new version
    # of the package.
    ensure_resource('class', 'tripleo::packages::upgrades', {
      'stage' => 'setup',
    })
}

enable_upgrade is defined as a boolean in the heat template, but ends up needing str2bool or it evaluates as true (I assume it's being cast to a string along the way, but I'm not yet sure if this has always been the case or a recent regression somewhere).

The fix seems to be str2bool in the packages.pp manifest

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/414228

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/414228
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=3d8dfa171437502721b599fd67e4fbd2951b7f4c
Submitter: Jenkins
Branch: master

commit 3d8dfa171437502721b599fd67e4fbd2951b7f4c
Author: Steven Hardy <email address hidden>
Date: Thu Dec 22 16:42:12 2016 +0000

    Ensure package updates don't happen unexpectedly

    I'm seeing this run yum update on deploy, even though hiera
    tripleo::packages::enable_upgrade says false.

    I assume these are needed because we're getting "false", but I'm
    unclear if this is a recently introduced problem (I only noticed it
    today as my image has outdated centos packages and it thus hung on
    step2 of the deploy.

    Change-Id: If09cdde9883f2674dbbc40944be5fe4445caa08e
    Closes-Bug: #1652107

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 6.2.0 release.