Not all sub-workflows calls are being passed the queue_name

Bug #1648781 reported by Dougal Matthews on 2016-12-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Medium
Dougal Matthews

Bug Description

In a number of places we make sub-workflows calls to call other workflows from inside the initial workflow. When this happens we don't always pass the queue_name, meaning that the sub-workflows are then sending messages back to the client on the default queue only. This means the CLI never sees these messages.

We need to check and update all the places this is missing.

Stretch goal: Find a way to check this doesn't happen again? Do we need a workflow linter?

Changed in tripleo:
status: Confirmed → In Progress
Changed in tripleo:
milestone: ocata-2 → ocata-3

Reviewed: https://review.openstack.org/406165
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=8490ebd7b5c25711e5faeef9094429fa764a8463
Submitter: Jenkins
Branch: master

commit 8490ebd7b5c25711e5faeef9094429fa764a8463
Author: Dougal Matthews <email address hidden>
Date: Fri Dec 2 14:59:45 2016 +0000

    When making sub-workflow calls, pass the queue_name

    When we make sud-workflow calls we should pass the queue name that was
    provided. At the moment, with the CLI, we are only getting messages from
    the "main" workflow, all the sub-workflow messages are going to the
    "tripleo" queue, which is currently only consumed by the GUI.

    Closes-Bug: #1648781
    Change-Id: Icfb25e66ea50a2d7371a5d1b5ba03c46095bc65e

Changed in tripleo:
status: In Progress → Fix Released

This issue was fixed in the openstack/tripleo-common 5.8.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers