Consistent positions and names for the UI buttons

[Michal Pryc]

Currently some of the "Save changes" are left to the "Cancel"

(Example is: Base resources configuration, user-environment.yaml Edit Configuration)

Then we get Register Node and "Register" is on the right from the Cancel.

That should be consistent across different UI dialogs (preferably similar to Horizon - right side = accept some option/save/deploy/register and Cancel to the left).

[Julie Pichon (jpichon)]

e.g. https://github.com/openstack/tripleo-ui/blob/master/src/js/components/nodes/RegisterNodesDialog.js

[Julie Pichon (jpichon)]

I like the idea of being consistent with the button placement, both internally and with Horizon.

[Liz Blanchard (lblanchard)]

+1 on this bug and the comments. For the TripleO UI, we are using PatternFly guidelines and here you can see the guideline on button placement within modals:
http://www.patternfly.org/pattern-library/forms-and-controls/forms/

The primary action should be on the right with the Cancel (or secondary) on the left. Both right aligned.

Based on this, the buttons on the Register Nodes modal is correct.

Here are the areas I noticed that need to be fixed:
1) Manage Plans -> Edit Plan / Create Plan (Should really have a title of edit or create plan and a confirmation of Save + Cancel)
2) Edit Configuration -> Overall Settings (Should have title of Edit Configuration and buttons should be in the opposite order so that Save and Close is right most)
3) Edit Configuration -> Parameters (Should have title of Edit Configuration and buttons "Save" and "Cancel")
4) Edit Role (Should have both "Save" and "Cancel" right aligned.)
5) Validations Details (Missing "Close" button in the bottom right.)
6) Tag Nodes into Profiles (Buttons should be swapped and "Confirm" should be "Tag Nodes".)

[Emilien Macchi (emilienm)]

There are no currently open reviews on this bug, changing the status back to the previous state and unassigning. If there are active reviews related to this bug, please include links in comments.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/539652

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/539652
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=714ce3edabdfb46f1fe374b64fc35e5cdad49378
Submitter: Zuul
Branch: master

commit 714ce3edabdfb46f1fe374b64fc35e5cdad49378
Author: Liz Blanchard <email address hidden>
Date: Wed Jan 31 14:44:12 2018 -0500

    Make button positions consistent

    This patch is an effort to make sure the button order in forms
    (typically modals) are consistent and following the PatternFly
    recommendations. The following forms buttons have been swapped
    in order so that the buttons are all right aligned at the bottom
    of the modals and the primary action is on the right while the
    secondary actions are on the left:
    - Import Plan Modal
    - Update Plan Modal
    - Deployment Configuration Modal (Overall Settings Tab)
    - Deployment Configuration Modal (Parameters Tab)
    - Role Configuration Modal
    - Manage Roles Modal
    - Delete Deployment Confirmation Modal
    - Delete Nodes Confirmation Modal (uses same code as delete
    deployment)
    - Tag Nodes Modal (Also updated button label to read "Tag Nodes"
    to be consistent terminology with all other buttons)

    Change-Id: Ib28cc4075ae69efe6ab2e73a95521de0a1b579a4
    Closes-Bug: #1647594

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ui 8.3.0 release.