Plan isn't purged of roles_data on a new create

[Steven Hardy]

When you create a stack which references a custom roles_data.yaml, you want that to be sticky when doing an update of the stack, but not when you've deleted the stack and are creating a new stack from scratch, e.g consider the following:

openstack overcloud deploy --templates -r my_roles_data.yaml
heat stack-delete overcloud
<wait for the stack to be deleted)
openstack overcloud deploy --templates

This second deploy will use the my_roles_data.yaml, which isn't very intuitive - we should detect that this is a clean deploy and completely delete/create the plan I think.

The workaround is to manually delete the plan, but I think we can optimize the workflow above by differentiating between a deploy (create) and deploy (update) command.

[Steven Hardy (shardy)]

Actually the reverse is also true - unlike all the -e options which are "sticky", if you forget to pass -r roles_data.yaml to any update, we ignore it as we purge everything from the --templates location and upload the default roles_data.yaml again.

So I think we'll need to rethink how/where this data is saved (move it to the mistral environment?)

[Brad P. Crochet (brad-9)]

The alternative command is to actually use 'openstack overcloud delete <stack>' command. This will delete both the stack and the plan.

[Toure Dunnon (toure)]

After looking into this issue the problem lies in the native heat clients inability to interface with swift to remove to once provided roles data. The OpenStack unified client places this data into the swift container and removes it upon deletion, to reference back what Brad stated. I would suggest not mixing the two clients in regards to a deployment workflow.

I will post an update to the clients release notes.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/570971

[Toure Dunnon (toure)]

fix it in docs: https://bugs.launchpad.net/tripleo/+bug/1783180