[RFE]: don't allow illegal characters in plan names

Bug #1644587 reported by Udi Kalifon on 2016-11-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Adriano Petrich

Bug Description

When creating a new plan, characters which are illegal in hostnames should also be illegal in the plan name. This is important because the nodes' host names are a concatenation of the plan name + role + index, by default.

For example, underscores are not allowed in host names. If I create a new plan and call it "plan_1" I will get nodes with names like plan_1-controller-X, plan_1-compute-X etc... This can cause some deployments to fail, for example I know that deployments with predictable IPs (from pools) fail when you do this.

Julie Pichon (jpichon) on 2016-11-24
tags: added: tripleoclient
Changed in tripleo:
status: New → Triaged
importance: Undecided → High
milestone: none → ocata-2
tags: added: tripleo-common

Fix proposed to branch: master
Review: https://review.openstack.org/405664

Changed in tripleo:
assignee: nobody → Adriano Petrich (apetrich)
status: Triaged → In Progress

Change abandoned by Adriano Petrich (<email address hidden>) on branch: master
Review: https://review.openstack.org/405664

Changed in tripleo:
assignee: Adriano Petrich (apetrich) → Dougal Matthews (d0ugal)
Changed in tripleo:
assignee: Dougal Matthews (d0ugal) → Adriano Petrich (apetrich)
Changed in tripleo:
milestone: ocata-2 → ocata-3

Fix proposed to branch: master
Review: https://review.openstack.org/411330

Changed in tripleo:
assignee: Adriano Petrich (apetrich) → Julie Pichon (jpichon)
Julie Pichon (jpichon) on 2016-12-15
Changed in tripleo:
assignee: Julie Pichon (jpichon) → Adriano Petrich (apetrich)
tags: removed: tripleoclient

Reviewed: https://review.openstack.org/411330
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=1a737d079422ce2b33fa61891f016f206c41e7f0
Submitter: Jenkins
Branch: master

commit 1a737d079422ce2b33fa61891f016f206c41e7f0
Author: Julie Pichon <email address hidden>
Date: Thu Dec 15 13:20:09 2016 +0000

    Disallow underscores in plan names

    Plan names are included in the node hostnames created during
    deployment. However underscores are not actually allowed in hostnames,
    and having them there can cause issues down the line.

    Change-Id: Ie8b9376e53a14b857836d90331ff32e5189d1574
    Partial-Bug: #1644587

Reviewed: https://review.openstack.org/407972
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=3f718ad23f6139d7665445996f67c6345a8f837b
Submitter: Jenkins
Branch: master

commit 3f718ad23f6139d7665445996f67c6345a8f837b
Author: Adriano Petrich <email address hidden>
Date: Wed Dec 7 09:41:09 2016 +0000

    Validate the plan name before running

    By default the plan name is used on the creation of the node name
    in the form of plan_name + role + index

    Forcing the plan name to be only letters and numbers removes the
    possibility of a failed deploy due to an invalid node name

    I've included a pattern validator to verify that those names are valid
    and a constant for node and plan name validation

    Change-Id: I111d0ba43d810657aa0b76b6ea4afd5175be1d30
    Closes-Bug: #1644587

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/420599
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=c960e2e52119a02ddce011feca99609eed954098
Submitter: Jenkins
Branch: stable/newton

commit c960e2e52119a02ddce011feca99609eed954098
Author: Julie Pichon <email address hidden>
Date: Thu Dec 15 13:20:09 2016 +0000

    Disallow underscores in plan names

    Plan names are included in the node hostnames created during
    deployment. However underscores are not actually allowed in hostnames,
    and having them there can cause issues down the line.

    Change-Id: Ie8b9376e53a14b857836d90331ff32e5189d1574
    Partial-Bug: #1644587
    (cherry picked from commit 1a737d079422ce2b33fa61891f016f206c41e7f0)

tags: added: in-stable-newton

This issue was fixed in the openstack/tripleo-common 5.8.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers