HA deployments disable keepalived in a non-composable way

[Steven Hardy]

We set a boolean here:

./puppet/services/pacemaker/haproxy.yaml: enable_keepalived: false

Which is then used here to conditionally disable the service at the puppet profile level:

https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/keepalived.pp#L35

This will not work for composable upgrades, as we'll think the service is enabled and start if after the upgrade completes.

Instead we should disable OS::TripleO::Services::Keepalived in t-h-t, either by mapping to OS::Heat::None or by removing it from the ControllerServices list for HA deployments

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/399554

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/399556

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/399554
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0f742c7ec93c1d13765e34876b087784fc529477
Submitter: Jenkins
Branch: master

commit 0f742c7ec93c1d13765e34876b087784fc529477
Author: Steven Hardy <email address hidden>
Date: Fri Nov 18 11:45:57 2016 +0000

    Disable keepalived for HA deployments via t-h-t

    Currently this is disabled via a conditional in the keepalived
    profile in puppet-tripleo, but this will be incompatible with
    the planned composable upgrades implementation. Instead we should
    disable the service template by mapping to OS::Heat::None, and
    ensure the haproxy manifest uses the t-h-t generated hiera value
    keepalived_enabled instead of hard-coding a hiera override in the
    haproxy template.

    Change-Id: I85a8b1cca7268506de22adfb3a8ce7faa4f157ef
    Partial-Bug: #1642936
    Depends-On: I90faf51881bd05920067c1e1d82baf5d7586af23

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steven Hardy (<email address hidden>) on branch: master
Review: https://review.openstack.org/399556
Reason: Obsoleted by https://github.com/openstack/puppet-tripleo/commit/87763459ae57614e092f772595a03e7d552f96d1

[Steven Hardy (shardy)]

https://review.openstack.org/#/c/399554/ is probably enough to close this I think.