AllNodesDeploySteps depends_on j2 templating is malformed

Bug #1642069 reported by Steven Hardy on 2016-11-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
High
Flavio Percoco

Bug Description

Corrected in https://review.openstack.org/#/c/330659/ but this is a bug not related to that containerization patch, we do j2 that results in:

  AllNodesDeploySteps:
    type: OS::TripleO::PostDeploySteps

    depends_on:
      - ControllerAllNodesDeployment

    depends_on:
      - ComputeAllNodesDeployment

    depends_on:
      - BlockStorageAllNodesDeployment

    depends_on:
      - ObjectStorageAllNodesDeployment

    depends_on:
      - CephStorageAllNodesDeployment

This actually means the depends_on is wrong, as only the last one will be respected.

Steven Hardy (shardy) on 2016-11-15
Changed in tripleo:
milestone: none → ocata-2
assignee: nobody → Steven Hardy (shardy)
importance: Undecided → High
status: New → In Progress
tags: added: newton-backport-potential
Changed in tripleo:
assignee: Steven Hardy (shardy) → Flavio Percoco (flaper87)

Reviewed: https://review.openstack.org/397983
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=8fe71c088889426f5a1547e96b47c569a0a0643c
Submitter: Jenkins
Branch: master

commit 8fe71c088889426f5a1547e96b47c569a0a0643c
Author: Steven Hardy <email address hidden>
Date: Tue Nov 15 22:49:18 2016 +0000

    Correct AllNodesDeploySteps depends_on

    This is wrong atm, it should loop to create a list for the depends_on
    not multiple depends_on statements.

    Note this was first corrected in https://review.openstack.org/#/c/330659/
    but we need it as a standalone patch that can be backported.

    Change-Id: I4d1d6346f2147e573fc0900038f1ad1d782e75ee
    Closes-Bug: #1642069

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/400661
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=74517c01255c7ebd42abccd3828f84cdaa839c32
Submitter: Jenkins
Branch: stable/newton

commit 74517c01255c7ebd42abccd3828f84cdaa839c32
Author: Steven Hardy <email address hidden>
Date: Tue Nov 15 22:49:18 2016 +0000

    Correct AllNodesDeploySteps depends_on

    This is wrong atm, it should loop to create a list for the depends_on
    not multiple depends_on statements.

    Note this was first corrected in https://review.openstack.org/#/c/330659/
    but we need it as a standalone patch that can be backported.

    Change-Id: I4d1d6346f2147e573fc0900038f1ad1d782e75ee
    Closes-Bug: #1642069
    (cherry picked from commit 8fe71c088889426f5a1547e96b47c569a0a0643c)

tags: added: in-stable-newton

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b2 development milestone.

This issue was fixed in the openstack/tripleo-heat-templates 5.2.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers