[instack-undercloud] puppet-stack-config.pp $pkg_upgrade_cmd default will always fail
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
Medium
|
Alex Schultz |
Bug Description
Our default for $pkg_upgrade_cmd will cause a failure for any non-RedHat osfamily. While it is pretty likely that we have other places in TripleO that break for non-rpm distros, I think it is still worth fixing this up.
Further details from Alex Shultz in https:/
"""
case $::osfamily {
'RedHat': {
$
}
default: {
warning(
"""
This should either be a fail or we need to specify $pkg_upgrade_cmd = 'true' or something because the exec below will just error if $pkg_upgrade_cmd is undef.
[root@host ~]# cat t.pp
exec { 'test':
command => $undef_variable,
path => '/usr/bin',
timeout => 0
}
[root@host ~]# puppet apply t.pp
Notice: Compiled catalog for packstack in environment production in 0.08 seconds
Error: test returned 1 instead of one of [0]
Error: /Stage[
Notice: Finished catalog run in 0.53 seconds
I like the idea of setting $pkg_upgrade_cmd = 'true' combined with making the warning a bit more clear on how someone would add update support for their distro.
I tried adding low-hanging-fruit tag... but launchpad is not cooperating.